fix: don't fail when checking the base
Metadata
Current evaluation
Merged PR #5388 in commit 5c43d861c, deferring base-check failures so invalid base definitions reach Snapcraft's user-friendly validation errors (SNAPCRAFT-313).
Resolution: closed resolved
Reason: PR #5388 was approved and merged as commit 5c43d861c, fixing premature failures during base checks so users receive the intended validation errors.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Minor improvement to keep snapcraft from failing early on incorrect base definitions before getting a chance to raise user-friendly errors.
(SNAPCRAFT-313)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5388 in commit 5c43d861c, deferring base-check failures so invalid base definitions reach Snapcraft's user-friendly validation errors (SNAPCRAFT-313). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5388 as commit 5c43d861c, deferring base-check failures so invalid base definitions can produce user-friendly errors. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #5388 in commit 5c43d861c, deferring base-check failures so incorrect bases receive user-friendly errors (SNAPCRAFT-313). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix preventing snapcraft from failing early during base checks. Enables user-friendly error reporting for incorrect bases. Approved by two reviewers and merged with 10 additions and 30 deletions across three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing snapcraft from failing early during base definition checks. The change allows the tool to gracefully raise user-friendly errors instead of crashing, addressing SNAPCRAFT-313. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2309 snap: improve early base detection logic | snapcraft | merged | Merged PR #2309 (commit 3565ed2e7), fixing early base detection when Snapcraft runs in a build provider outside the project directory (LP #1795501). | |
| #6499 fix: parse build-base for snapcraftctl validation | snapcraft | merged | Fixed a validator bug preventing core22/core24 snaps without a `base` key from using `snapcraftctl`. Merged as #6499, resolving #6336. | |
| #6193 fix: snapcraft try error shows effective base | snapcraft | merged | Merged PR #6193 fixed `snapcraft try` to report the project's effective base via `get_effective_base()`, with core24 and core26 test coverage, in commit bcae1c3ed. | |
| #6187 Fix snapcraft try error to show actual base | snapcraft | closed | Closed unmerged over contribution-guideline concerns; PR #6193 later fixed #6186 by using the effective project base in commit bcae1c3ed. | |
| #4274 bases: improve errors for ESM bases | snapcraft | merged | Merged PR #4274 as dbe76f21d, improving unsupported ESM-base errors to identify prior supported Snapcraft versions/channels and fixing #4246. | |
| #761 models/project.py: do not check for base when build-base: devel | craft-application | closed | Rejected unmerged: craft-application retained default devel base/build-base validation; Snapcraft was told to add a gadget-specific _validate_devel_base override. | |
| #4580 fix: do not propagate build-base to snap.yaml | snapcraft | merged | Merged #4580 (d4e948f33), preventing build-base from being propagated into generated snap.yaml files. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged #4755, fixing the devel-base integration test to verify Snapcraft can create the base snap and that the resulting devel base is usable. | |
| #4562 Validity of `base` is not checked when using `--destructive-mode` | snapcraft | closed | Base validation in destructive mode was fixed in Snapcraft 8.1 via craft-application 2.0 and canonical/craft-application PR #263. |