fix: don't fail when checking the base
Metadata
Current evaluation
Merged a fix preventing snapcraft from failing early during base checks. Enables user-friendly error reporting for incorrect bases. Approved by two reviewers and merged with 10 additions and 30 deletions across three files.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Minor improvement to keep snapcraft from failing early on incorrect base definitions before getting a chance to raise user-friendly errors.
(SNAPCRAFT-313)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix preventing snapcraft from failing early during base checks. Enables user-friendly error reporting for incorrect bases. Approved by two reviewers and merged with 10 additions and 30 deletions across three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing snapcraft from failing early during base definition checks. The change allows the tool to gracefully raise user-friendly errors instead of crashing, addressing SNAPCRAFT-313. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing snapcraft from failing early on incorrect base definitions, enabling user-friendly error messages instead. Resolves SNAPCRAFT-313. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6193 fix: snapcraft try error shows effective base | snapcraft | merged | Merged fix for #6186 that updates the snapcraft try error message to accurately display the effective base using get_effective_base(). Approved by reviewers and merged with added unit tests for core24 and core26. | |
| #2309 snap: improve early base detection logic | snapcraft | merged | Merged. Resolved early base detection failure in build providers by updating logic to account for snapcraft's non-project directory execution. Approved by reviewer, passed CI, and merged with minimal changes. | |
| #4274 bases: improve errors for ESM bases | snapcraft | merged | Merged into main. Updates error handling for deprecated ESM bases to reference the specific Snapcraft version and channel where they were supported. Resolves #4246. Approved by reviewer and passed CI. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #3180 build providers: nice message on bad base | snapcraft | merged | Merged implementation adding a new exception to handle invalid bases in LXD build providers, providing clearer error messages. Resolves SNAPCRAFT-1H2. Approved by one reviewer, passed CI, and modified 4 files (+77/-14). | |
| #3631 parts: add early base parsing (CRAFT-766) | snapcraft | merged | Merged into snapcraft/7.0. Adds early base parsing for lifecycle commands, verifying the base entry via project YAML and falling back to legacy handlers if not core22. Approved, passed CI, +0.81% coverage. | |
| #3836 snapcraft/meta: make Manifest.base optional | snapcraft | merged | Merged a fix making Manifest.base optional to resolve a validation error crashing manifest generation for core22 base snaps. Approved and merged after passing CI. Reviewers suggested adding a spread test for base building cases. | |
| #4580 fix: do not propagate build-base to snap.yaml | snapcraft | merged | Merged a fix preventing build-base from propagating to snap.yaml. The pull request received two approvals, passed CI checks and code coverage, and was successfully integrated. | |
| #6338 docs: update supported bases | snapcraft | merged | Merged documentation update reflecting Snapcraft 9 as the preferred version for core22, core24, and core26 bases. Approved by three reviewers and passed CI checks. | |
| #1004 fix: unhelpful error message when `base` is missing from YAML | rockcraft | merged | Merged a fix that improves the error message when the base field is missing from YAML, resolving issue 997. Approved by two reviewers, the PR passed CI checks aside from unrelated known failures, and was successfully integrated. |