← Back to issue list

style: fix linting errors for ruff 0.12.0

View original Github issue

Metadata

Project
craft-parts
Number
#1156
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit eb82b792 with all CI checks passing (linters, unit-tests, tests), satisfying the two reviewer approvals. It applied the fixes required by the Ruff 0.12.0 upgrade.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/craft-parts#1156 via commit eb82b792, fixing Ruff 0.12.0 lint errors in five files; all CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
qwen3.6-35b-a3b-mtp-q6 — — Merged style fixes resolving linting errors introduced by the ruff 0.12.0 update. The maintainer-submitted changes align the codebase with the new linter version and were accepted without additional review comments.

Update history

No update history recorded yet.

Related work

  • Caused By: craft-parts#407 (confidence 78%)

    Commit c576d420 'build(deps): update pre-commit hook astral-sh/ruff-pre-commit to v0.12.0' introduced the new lint failures that #1156 fixed.

  • Related To: craft-parts#1465 (confidence 45%)

    Later 'style: fix linting issues for newer ruff' PR applying the same recurring maintenance for subsequent Ruff upgrades.

Related issues

Issue Project State Summary Similarity
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
93%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
91%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
90%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
90%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed.
90%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged as commit f1427855: small Ruff 0.9 lint fixes (+2/-1) across 2 files, following the ruff-pre-commit hook bump to the 0.9.x series.
89%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
88%
#19 style: fix linting issues for ruff 0.12 craft-artifacts closed PR #19 was closed unmerged after prolonged inactivity; its Ruff 0.12 lint fixes were abandoned. Later PR #20 was merged as commit 04cbdc0.
88%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
88%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged #165, incorporating canonical/starbase#408, with a four-file Ruff 0.12 compatibility style update (+7/-7).
87%