← Back to issue list

style: fix lints from ruff 0.12

View original Github issue

Metadata

Project
craft-cli
Number
#357
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed.

Resolution: closed resolved

Reason: PR craft-cli#357 was merged as commit dd635c9. It resolved the Ruff 0.12 lint failures after three approvals, with every CI check passing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Fixes some new lint errors that came in from Ruff 0.12.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #357 as commit dd635c9, resolving Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed after three approvals.
stealth/space-bunny-alpha — closed resolved Merged PR #357 as commit dd635c9 ("style: fix lint errors from ruff 0.12"), applying style-only fixes across 7 files (+11/-10) for new Ruff 0.12 lint failures. Approved by 3 reviewers; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #357, fixing Ruff 0.12 lint errors across seven files (+11/-10) after three approvals and all CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
92%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
90%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
90%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
89%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
88%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors.
87%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
87%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
87%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged PR #4981 as commit 3a1b8a949, fixing Ruff 0.6 lint errors with a minimal one-file change.
87%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged as commit f1427855: small Ruff 0.9 lint fixes (+2/-1) across 2 files, following the ruff-pre-commit hook bump to the 0.9.x series.
86%