← Back to issue list

style: fix lints from ruff 0.12

View original Github issue

Metadata

Project
craft-cli
Number
#357
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Fixes some new lint errors that came in from Ruff 0.12.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer pull request resolving lint errors introduced by the Ruff 0.12 update. The changes pass make lint and make test, updating the codebase to comply with the new static analysis rules.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
94%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
93%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
93%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
93%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
92%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged a minor style fix addressing linting issues for ruff 0.9. Approved by two reviewers, passed CI checks, and updated two files with a net change of one line.
92%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged after approval by two reviewers and passing CI. The change updates the codebase to comply with ruff 0.5 linting rules, adjusting style configurations and fixing formatting across one file.
91%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged following two reviewer approvals and passing CI. The change resolves ruff 0.6.0 linting errors across 31 files using ruff's autofix, resulting in 70 additions and 71 deletions.
91%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change.
91%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged a pre-emptive linting update for ruff 0.12 compatibility. Approved by two reviewers and passed CI. The change adjusts formatting across four files to prevent breaking changes when the snap reaches stable.
90%