← Back to issue list

feat(grammar): support 'for' statements

View original Github issue

Metadata

Project
craft-application
Number
#868
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged opt-in support for for statements in the grammar. Implementation allows independent activation in imagecraft while awaiting broader grammar redesign. Approved by reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Adds support for the `for` keyword. Blocked by https://github.com/canonical/craft-grammar/pull/118 (IMAGECRAFT-42)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged opt-in support for for statements in the grammar. Implementation allows independent activation in imagecraft while awaiting broader grammar redesign. Approved by reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged opt-in support for for-loop statements in the grammar. The change enables for loops in imagecraft independently while awaiting the broader grammar redesign. Resolved upstream dependency and integrated successfully.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#203 feat: support 'for' statements imagecraft merged Merged after adding 'for' statement support to the advanced grammar. Approved by two reviewers, passed all CI checks, and resolves #201. Changes affect 10 files.
76%
#108 feat: add 'for' statement craft-grammar merged Merged. Implemented a for statement in craft-grammar, adding integration tests per reviewer feedback. CI passed and three reviewers approved. Minor null-handling feedback was deferred to future issues.
73%