← Back to issue list

feat: add 'for' statement

View original Github issue

Metadata

Project
craft-grammar
Number
#108
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Merged. Implemented a for statement in craft-grammar, adding integration tests per reviewer feedback. CI passed and three reviewers approved. Minor null-handling feedback was deferred to future issues.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Adds a `for` statement to craft-grammar. This is the first step towards a new variant of advanced grammar, so some restrictions apply: - 'for' can't be combined with other statements. - only one selector may be used in a 'for' statement (`for a,b` is invalid) (IMAGECRAFT-38)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Implemented a for statement in craft-grammar, adding integration tests per reviewer feedback. CI passed and three reviewers approved. Minor null-handling feedback was deferred to future issues.
qwen3.6-35b-a3b-mtp-q6 — — Merged a squashed PR adding a for statement to craft-grammar with usage restrictions. Integration tests were added per feedback. A minor null organization edge case was deferred to future issues.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#203 feat: support 'for' statements imagecraft merged Merged after adding 'for' statement support to the advanced grammar. Approved by two reviewers, passed all CI checks, and resolves #201. Changes affect 10 files.
81%
#129 feat: add "any" as an always-on value for "for" grammar craft-grammar merged Merged feature adding "any" as an always-on value for the "for" grammar. Approved by two reviewers with all CI checks passing. Resolves #122 and CRAFT-4741 across 12 files.
73%
#868 feat(grammar): support 'for' statements craft-application merged Merged opt-in support for for statements in the grammar. Implementation allows independent activation in imagecraft while awaiting broader grammar redesign. Approved by reviewers and passed CI checks.
73%
#137 feat(for-grammar): add an 'else' clause craft-grammar merged Merged. Adds an else clause to the for grammar, matching to grammar behavior without recursive processing. Approved by two reviewers, passed CI checks, and resolves #134 and CRAFT-4768.
72%
#213 docs: add 'Platform grammar' reference imagecraft merged Merged documentation for the for statement and platform grammar. Approved by three reviewers and passed all CI checks. Includes placeholders for Craft Grammar 2.3.0 features, now enabled following PR 207.
71%