← Back to issue list

feat: support 'for' statements

View original Github issue

Metadata

Project
imagecraft
Number
#203
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged after adding 'for' statement support to the advanced grammar. Approved by two reviewers, passed all CI checks, and resolves #201. Changes affect 10 files.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Adds support for the 'for' statement in advanced grammar. I did a bit of prep-work and refactoring, so I recommend reviewing per-commit. Fixes #201 (IMAGECRAFT-45)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after adding 'for' statement support to the advanced grammar. Approved by two reviewers, passed all CI checks, and resolves #201. Changes affect 10 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds 'for' statement support to the advanced grammar with preparatory refactoring. Fixes #201. Lint and test suites passed.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Implements 'for' statement support in the advanced grammar, including preparatory refactoring. Resolves issue #201.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#108 feat: add 'for' statement craft-grammar merged Merged. Implemented a for statement in craft-grammar, adding integration tests per reviewer feedback. CI passed and three reviewers approved. Minor null-handling feedback was deferred to future issues.
81%
#868 feat(grammar): support 'for' statements craft-application merged Merged opt-in support for for statements in the grammar. Implementation allows independent activation in imagecraft while awaiting broader grammar redesign. Approved by reviewers and passed CI checks.
76%
#1817 grammar: support strings snapcraft merged Merged following two approvals and passing CI checks. Implements generic support for processing grammar of string values, starting with the source property. Closes issues #1686 and #1687.
72%
#129 feat: add "any" as an always-on value for "for" grammar craft-grammar merged Merged feature adding "any" as an always-on value for the "for" grammar. Approved by two reviewers with all CI checks passing. Resolves #122 and CRAFT-4741 across 12 files.
71%
#150 feat: evaluate project using grammar rules craft-application merged Merged after approval and passing CI. Implements dual grammar evaluation to transparently resolve build plans and target architectures. Minor coverage gaps were noted but did not block the merge.
70%