← Back to issue list

feat(ProjectService): make check_supported_base work with bare base

View original Github issue

Metadata

Project
craft-application
Number
#876
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 68bdfc6c (PR #876): ProjectService.check_supported_base now handles bare bases via project.effective_base. Builds on merged PR #874; all CI passed, 3 approvals.

Resolution: closed resolved

Reason: PR #876 was merged into craft-application as commit 68bdfc6c with approved review and all CI checks passing. The lifecycle code now uses project_service.get().effective_base with is_effective_base_eol()/base_eol_soon_date(), and a spread test was added at tests/spread/witchcraft/pack/bare-base/witchcraft.yaml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Builds on top of #874. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 68bdfc6c (PR #876): ProjectService.check_supported_base now handles bare bases via project.effective_base. Builds on merged PR #874; all CI passed, 3 approvals.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#876 as 68bdfc6c, enabling ProjectService.check_supported_base to work with a bare base. All CI checks passed and three reviewers approved.
stealth/space-bunny-alpha — closed resolved Merged craft-application PR #876 in commit 68bdfc6c, adding bare-base support to ProjectService.check_supported_base. Three reviewers approved and all CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged update to ProjectService.check_supported_base enabling bare base support. Builds on PR #874, approved by three reviewers, and passed all CI checks. Changes span nine files with 122 additions and 9 deletions.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#874 (confidence 90%)

    PR #876 explicitly states it builds on top of merged PR #874, which reset craft-parts callbacks and included spread tests for witchcraft.

  • Related To: canonical/craft-application#873 (confidence 45%)

    Issue #873 is reported as fixed by PR #874, the base PR this change depends on.

Related issues

Issue Project State Summary Similarity
#36 project: support build-base and allow 'bare' bases rockcraft merged Merged in #36 as commit 5a27aca4, adding build-base, bare bases, and Ubuntu 22.04 support; follow-up commit d1a5f04c corrected a bare-base rebuild bug.
74%