← Back to issue list

test: simpler checker no-op for grammar

View original Github issue

Metadata

Project
craft-application
Number
#899
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Simplifies the grammar checker no-op in craft_application/grammar.py (+1/-8 lines). Approved by 1 reviewer, all CI passing, but unmerged for 356 days. The self_check function and checker=self_check still exist in main.

Suggested action: keep open

Reason: The PR is approved, all CI checks pass, and the targeted code (self_check function and checker=self_check at grammar.py:181-191) still exists unchanged in main. The referenced craft-grammar#131 is closed, confirming the dependency is resolved. The change remains valid and applicable despite 356 days of inactivity.

Impact: 10 Quick Win: 9.5 Staleness: 75 Complexity: 5 Confidence: 72

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 10
Quick Win: 9.5
Staleness: 75
Complexity: 5
Confidence: 72
keep open Simplifies the grammar checker no-op in craft_application/grammar.py (+1/-8 lines). Approved by 1 reviewer, all CI passing, but unmerged for 356 days. The self_check function and checker=self_check still exist in main.
qwen/qwen3.6-35b-a3b
Staleness: 80
Complexity: 10
Confidence: 85
needs review Test update simplifying grammar checker to a no-op. Approved, all CI passing, but inactive for ~315 days. Ready to merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 80
close stale Adds a simpler no-op checker test for the grammar module. The PR has been inactive for over 10 months with no CI results or maintainer feedback.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 15
Confidence: 75
close stale Introduces a simpler no-op checker for grammar tests to resolve issue #131. Open for 280 days with no labels or recent activity, the pull request remains unreviewed and awaiting maintainer attention.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-grammar#131 (confidence 85%)

    PR comment states 'Fixes' this issue; craft-grammar#131 made the checker parameter optional with a lambda default, enabling this cleanup in craft-application to remove the now-unnecessary self_check no-op.

Related issues

No related issues found above the similarity threshold.