← Back to issue list

test: simpler checker no-op for grammar

View original Github issue

Metadata

Project
craft-application
Number
#899
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes the `self_check` no-op workaround from craft_application/grammar.py now that craft-grammar>=2.3.0 makes GrammarProcessor.checker optional (fixes craft-grammar#131). Approved, all CI green, open 388 days.

Suggested action: needs review

Reason: The diff is a trivial +1/-8 internal cleanup that drops the `value == value` self_check hack and its '# TODO: make checker optional in craft-grammar' noqa, which is now satisfiable: pyproject.toml already requires craft-grammar>=2.3.0 and craft-grammar's changelog for 2.3.0 states 'The ``checker`` option for ``GrammarProcessor`` is now optional'. The PR is approved (1 reviewer), has0 unresolved review comments and every CI check passing, so it is technically ready to land; actionability is discounted only because grammar.py was rewritten by later commits (#908 duplicate-key check, #1084 mypy/pyright→ty, #1188 build-slice support), so a rebase is likely needed and the 388-day dormancy suggests no one is driving it to merge.

Evaluated by: mr-cal-bot

Impact: 15 Quick Win: 10 Complexity: 5 Confidence: 85 Actionability: 68

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 15
Quick Win: 10
Complexity: 5
Confidence: 85
Actionability: 68
needs review Removes the `self_check` no-op workaround from craft_application/grammar.py now that craft-grammar>=2.3.0 makes GrammarProcessor.checker optional (fixes craft-grammar#131). Approved, all CI green, open 388 days.
qwen/qwen3.6-35b-a3b
Impact: 5
Quick Win: 1
Complexity: 5
Confidence: 70
Actionability: 20
close stale Test change simplifying checker no-op for grammar. Approved by 1 reviewer, all CI passing, but inactive for 376 days. References craft-grammar#131 which is already closed.
qwen/qwen3.8-27b
Impact: 10
Quick Win: 10
Staleness: 75
Complexity: 5
Confidence: 72
keep open Simplifies the grammar checker no-op in craft_application/grammar.py (+1/-8 lines). Approved by 1 reviewer, all CI passing, but unmerged for 356 days. The self_check function and checker=self_check still exist in main.
qwen/qwen3.6-35b-a3b
Staleness: 80
Complexity: 10
Confidence: 85
needs review Test update simplifying grammar checker to a no-op. Approved, all CI passing, but inactive for ~315 days. Ready to merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 80
close stale Adds a simpler no-op checker test for the grammar module. The PR has been inactive for over 10 months with no CI results or maintainer feedback.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-grammar#133 (confidence 92%)

    craft-grammar#131 ('Checker for grammar processor should be optional') was fixed by craft-grammar#133, commit 9b70aa6, shipped in craft-grammar 2.3.0 — this PR is the downstream cleanup that becomes possible after it.

  • Blocked By: canonical/craft-grammar#130 (confidence 45%)

    craft-grammar#130 added optional valid_platforms/valid_architectures to GrammarProcessor, an alternative and arguably cleaner replacement for the checker hack this PR simply deletes; not required for this change.

Related issues

Issue Project State Summary Similarity
#131 Checker for grammar processor should be optional craft-grammar closed Resolved: PR canonical/craft-grammar#133 (commit 9b70aa6) merged, making GrammarProcessor's checker optional with a default no-op lambda, closing #131.
74%