← Back to issue list

build(deps): loosen pygit2 dependency

View original Github issue

Metadata

Project
craft-application
Number
#935
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after passing CI and receiving three approvals. Loosens pygit2 dependency to support versions up to 1.17, enabling Ubuntu core26 compatibility and resolving pyright type complaints.

Suggested action:

No scores available.

Issue body

I've checked that craft-application works with each intermediate version of pygit2 up to and including the latest. This is done for two reasons: 1. Will be needed for the core26 switch (25.10 uses pygit2 1.17 and libgit2 1.9) 2. Fixes pyright complaints about untyped parts of pygit2 1.14 Fixes #593 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after passing CI and receiving three approvals. Loosens pygit2 dependency to support versions up to 1.17, enabling Ubuntu core26 compatibility and resolving pyright type complaints.
qwen3.6-35b-a3b-mtp-q6 Merged to loosen pygit2 version constraints, enabling compatibility with versions 1.14 through 1.17. This resolves pyright type-checking errors and supports the core26 platform transition. Closes #593.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2676 build(deps): enable newer pygit2 on Ubuntu 26.04 charmcraft merged Merged to enable newer pygit2 on Ubuntu 26.04. Approved by two reviewers. CI included failing snap tests and type checking warnings, but notifications were non-blocking. Changes modified four files (+108/-13).
83%
#336 build(deps): use a newer pygit2 on Python 3.14 imagecraft merged Merged an update to use a newer pygit2 version for Python 3.14 compatibility. Approved by two reviewers and passed all CI checks. The change removes the need to build an older pygit2 on resolute, simplifying dependency management.
82%
#243 build(deps): make pygit2 a required dependency craft-application merged Merged to make pygit2 a required dependency. Approved by two reviewers. The update modifies one file with a +8/-8 line change.
80%
#5897 build(deps): update dependencies snapcraft merged Merged dependency updates for Python packages, schema, pygit2, and libgit2. CI showed flaky test failures on Ubuntu 22.04/24.04 attributed to unrelated environment bugs, but the maintainer proceeded with the merge after approval.
77%
#210 build: broaden pygit2 dependency to include 1.14 craft-application merged Merged after broadening the pygit2 dependency to include version 1.14. Prevents Renovate from attempting further updates and resolves a test compatibility issue for 1.14+. Approved by two reviewers with passing CI checks.
76%
#534 build(deps): update dependency pygit2 to >=1.16.0,<1.17.0 (hotfix/4.6) - autoclosed craft-application closed Renovate bot PR updating pygit2 to >=1.16.0,<1.17.0 was autoclosed without review or CI checks. The dependency update was abandoned and not merged.
74%
#5263 build(deps): update dependency pygit2 to ~=1.17.0 (main) snapcraft closed Closed without merging due to a uv.lock dependency resolution failure during the pygit2 update to 1.17.0. Renovate will ignore this update and automatically generate a replacement PR for a newer version.
74%
#1834 build(deps): update dependency pygit2 to v1.15.1 (main) charmcraft closed Closed without merging. The pygit2 dependency update to v1.15.1 was rejected. Renovate will ignore this version and automatically generate a replacement pull request when a newer release becomes available.
73%
#266 build(deps): update pyright craft-application merged Merged the pyright dependency update following three reviewer approvals and passing CI checks. The minimal changes affected two files.
71%
#701 build(deps): update pyright to 1.1.358 craft-parts merged Merged update to pyright version 1.1.358. Approved by two reviewers and passed CI. A lint issue was addressed separately in PR #702. The change modified three files with minimal adjustments.
70%