← Back to issue list

chore: fix pyright error

View original Github issue

Metadata

Project
craft-archives
Number
#158
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #158 as commit fc48bed, fixing a Pyright error with a one-line deletion despite a failing minimum-dependencies job.

Resolution: closed resolved

Reason: PR #158 was merged as commit fc48bed. Its one-file, one-line deletion fixed the Pyright error and received approval from three reviewers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #158 as commit fc48bed, fixing a Pyright error with a one-line deletion despite a failing minimum-dependencies job.
stealth/space-bunny-alpha — closed resolved Merged craft-archives#158 (fc48bed), fixing a Pyright error with a one-line deletion. Approved by three reviewers, although minimum-dependency tests failed.
stealth/space-bunny-alpha — closed resolved Merged PR #158 fixed a Pyright error by deleting one line; commit fc48bed integrates the change.
qwen/qwen3.6-35b-a3b — — Merged a maintainer's pull request that resolved a pyright error by removing a single line. Approved by three reviewers and passed CI checks before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#117 chore: fix pyright config craft-store merged Pyright configuration fixes from #117 were approved by two reviewers and merged into the project.
85%
#228 chore(deps): update dependency types/pyright to v1.1.374 - autoclosed starbase closed Renovate PR #228 was autoclosed unmerged; merged PR #234 superseded it by bumping Pyright from 1.1.372 to 1.1.375 in commit d88dde5.
82%
#70 chore(deps): update pyright to v1.1.309 starbase merged Renovate dependency bump PR #70 raising pyright/types-pyright from 1.1.308 to 1.1.309 was approved and merged into main (2-line pin change, automerge enabled).
81%
#784 chore(deps): update bugfixes craft-parts merged Merged PR #784 in commit 764786e7, updating pyright 1.1.358→1.1.372 and tox-gh 1.3→1.3.2.
81%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged PR #181 merged into main as commit d34fdd6 (Sep 2023): added typing stub dependencies and fixed the resulting Pyright errors, a 1-file, +6/-1 lint/tooling change.
80%
#439 chore(linter): misc fix rockcraft merged Merged PR #439, applying miscellaneous linter fixes across 16 files, including a Pyright error exposed after rebasing onto main.
79%
#613 chore(deps): update dependency pyright to v1.1.348 craft-parts closed Closed unmerged after the Pyright 1.1.348 update was superseded by merged PR canonical/craft-parts#639 in commit 162a3522.
79%
#234 chore(deps): update dependency pyright to v1.1.375 starbase merged Merged Renovate PR #234, bumping pyright from 1.1.372 to 1.1.375; the change landed in commit d88dde5.
79%
#206 chore(deps): update dependency types/pyright to v1.1.359 starbase merged Merged PR #206 updated types/pyright from 1.1.358 to 1.1.359 via commit 06f6913.
78%
#196 chore(deps): update dependency types/pyright to v1.1.356 starbase merged Merged PR #196 updated types/pyright from 1.1.355 to 1.1.356 via commit 5d10b2a.
78%