← Back to issue list

chore: fix pyright config

View original Github issue

Metadata

Project
craft-store
Number
#117
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after two reviewers approved and CI checks passed. The pull request updates the pyright configuration across two files, adding 24 lines and removing 16 to resolve type-checking setup issues.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two reviewers approved and CI checks passed. The pull request updates the pyright configuration across two files, adding 24 lines and removing 16 to resolve type-checking setup issues.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer's pull request that corrected the pyright configuration. Changes passed automated checks and were integrated into the codebase without further discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#158 chore: fix pyright error craft-archives merged Merged a maintainer's pull request that resolved a pyright error by removing a single line. Approved by three reviewers and passed CI checks before integration.
90%
#70 chore(deps): update pyright to v1.1.309 starbase merged Merged automated dependency update for pyright and types/pyright from v1.1.308 to v1.1.309. Approved by one reviewer, passed CI checks, and merged automatically via Renovate bot configuration.
82%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration.
82%
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
82%
#399 chore(lint): set user-provided pyright venv craft-application merged Merged a maintainer's chore to switch pyright from a tox-provided to a user-provided virtual environment. Approved by two reviewers, passed CI, and removed two lines from one file.
79%
#234 chore(deps): update dependency pyright to v1.1.375 starbase merged Merged an automated dependency update for pyright from v1.1.372 to v1.1.375. Approved by a reviewer, passed CI checks, and automatically merged via Renovate bot.
78%
#251 chore(deps): update dependency types/pyright to v1.1.359 craft-cli merged Merged automated dependency update for types/pyright from v1.1.358 to v1.1.359. Approved by two reviewers, passed CI checks, and automatically merged via Renovate bot configuration. Single file change.
78%
#439 chore(linter): misc fix rockcraft merged Merged linter chore PR fixing miscellaneous issues and an unexpected pyright error from a rebase onto main. Approved by two reviewers, changes span 16 files with 86 additions and 76 deletions.
78%
#135 chore(deps): update dependency types/pyright to v1.1.339 craft-store merged Merged automated dependency update for types/pyright from v1.1.338 to v1.1.339. Approved by two reviewers, passed CI, and auto-merged via Renovate bot configuration.
78%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
77%