← Back to issue list

chore: fix pyright config

View original Github issue

Metadata

Project
craft-store
Number
#117
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Pyright configuration fixes from #117 were approved by two reviewers and merged into the project.

Resolution: closed resolved

Reason: Pull request craft-store#117 was merged after approval by two reviewers, completing the configuration fix across two files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Pyright configuration fixes from #117 were approved by two reviewers and merged into the project.
stealth/space-bunny-alpha — closed resolved Merged craft-store#117, updating Pyright configuration in two files (+24/-16). The change was approved by two reviewers with no unresolved comments.
qwen/qwen3.6-35b-a3b — — Merged after two reviewers approved and CI checks passed. The pull request updates the pyright configuration across two files, adding 24 lines and removing 16 to resolve type-checking setup issues.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#158 chore: fix pyright error craft-archives merged Merged PR #158 as commit fc48bed, fixing a Pyright error with a one-line deletion despite a failing minimum-dependencies job.
85%
#70 chore(deps): update pyright to v1.1.309 starbase merged Renovate dependency bump PR #70 raising pyright/types-pyright from 1.1.308 to 1.1.309 was approved and merged into main (2-line pin change, automerge enabled).
81%
#1848 chore(renovate): always update pyright on its own charmcraft merged Merged PR #1848 as commit ad44cd47, configuring Renovate to update pyright independently; approved by two reviewers.
80%
#228 chore(deps): update dependency types/pyright to v1.1.374 - autoclosed starbase closed Renovate PR #228 was autoclosed unmerged; merged PR #234 superseded it by bumping Pyright from 1.1.372 to 1.1.375 in commit d88dde5.
78%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged PR #181 merged into main as commit d34fdd6 (Sep 2023): added typing stub dependencies and fixed the resulting Pyright errors, a 1-file, +6/-1 lint/tooling change.
77%
#314 chore(deps): update dependency types/pyright to v1.1.359 craft-application merged Renovate bumped types/pyright from 1.1.358 to 1.1.359 in dev dependencies; approved (2 reviewers) and merged to main as commit 3adbe37d (April 2024).
76%
#439 chore(linter): misc fix rockcraft merged Merged PR #439, applying miscellaneous linter fixes across 16 files, including a Pyright error exposed after rebasing onto main.
76%
#613 chore(deps): update dependency pyright to v1.1.348 craft-parts closed Closed unmerged after the Pyright 1.1.348 update was superseded by merged PR canonical/craft-parts#639 in commit 162a3522.
76%
#588 chore(deps): update dependency pyright to v1.1.337 craft-parts merged Renovate PR merged as commit a095fbf8, bumping the pinned pyright dev dependency from ==1.1.327 to ==1.1.337 in craft-parts (approved by 2 reviewers).
76%
#784 chore(deps): update bugfixes craft-parts merged Merged PR #784 in commit 764786e7, updating pyright 1.1.358→1.1.372 and tox-gh 1.3→1.3.2.
75%