← Back to issue list

lint: fix lint issues with newer ruff

View original Github issue

Metadata

Project
craft-archives
Number
#33
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- A ruff update that added some more checks and a PR being merged around the same time left us with linting issues.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
qwen3.6-35b-a3b-mtp-q6 Merged to fix linting failures from a newer ruff version. Coverage unchanged. Unit tests deferred to a separate ticket. Approved and merged after maintainer review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#68 lint: update ruff and fix linting craft-archives merged Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change.
92%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged after two approvals and passing all CI checks. Resolves linting compatibility issues with newer ruff versions, updating five files.
91%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
89%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
88%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
88%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
87%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
87%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged a minor style fix addressing linting issues for ruff 0.9. Approved by two reviewers, passed CI checks, and updated two files with a net change of one line.
87%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
86%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged a pre-emptive linting update for ruff 0.12 compatibility. Approved by two reviewers and passed CI. The change adjusts formatting across four files to prevent breaking changes when the snap reaches stable.
86%