← Back to issue list

lint: fix lint issues with newer ruff

View original Github issue

Metadata

Project
craft-archives
Number
#33
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit c2a6687 ('lint: fix lint issues with newer ruff (#33)') after a single approval; the new Ruff checks it triggered are now clean. Follow-up test coverage was deliberately deferred to ticket CRAFT-1641 per the maintainer's comment.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- A ruff update that added some more checks and a PR being merged around the same time left us with linting issues.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641.
stealth/space-bunny-alpha — closed resolved Merged as c2a6687 (PR #33), fixing newer Ruff lint checks across three files; additional unit tests were deferred to CRAFT-1641.
stealth/space-bunny-alpha — closed resolved Merged PR #33 (949ae2f), fixing newer Ruff lint violations in three files. Additional unit tests were deferred to CRAFT-1641.
qwen/qwen3.6-35b-a3b — — Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-archives#11 (confidence 40%)

    Earlier attempt to pin a single Ruff version to avoid CI breakages from rolling linter updates.

Related issues

Issue Project State Summary Similarity
#68 lint: update ruff and fix linting craft-archives merged Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67.
86%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
86%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
86%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
84%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
84%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers.
83%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
83%
#29 style(lint): fix ruff 0.6.0 linting errors craft-platforms merged Merged PR #29 as commit 399c4e0, fixing Ruff 0.6.0 lint errors and switching the pre-commit Ruff hook to rolling versions.
83%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
82%
#19 style: fix linting issues for ruff 0.12 craft-artifacts closed PR #19 was closed unmerged after prolonged inactivity; its Ruff 0.12 lint fixes were abandoned. Later PR #20 was merged as commit 04cbdc0.
82%