← Back to issue list

lint: bump pylint

View original Github issue

Metadata

Project
snapcraft
Number
#3813
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit 522b301a9: updated Pylint and removed a redundant too-many-lines suppression across three files.

Resolution: closed resolved

Reason: PR #3813 was approved and merged as commit 522b301a9. The merged change bumps Pylint and removes the obsolete lint suppression.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Bump pylint to latest version, remove redundant `disable: too-many-lines`. Part 2 of supporting architectures for `core22`. Full code change is proposed [here](https://github.com/snapcore/snapcraft/pull/3712). This is no longer strictly required for architectures support since Claudio bumped the major version (2.13->2.14) last week. I'm still pushing it, as it's a simple update. (CRAFT-1164)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit 522b301a9: updated Pylint and removed a redundant too-many-lines suppression across three files.
stealth/space-bunny-alpha — closed resolved PR #3813 (commit 522b301a9) merged into main: bumped pylint and dropped a redundant `too-many-lines` disable; lint-only, no coverage change.
stealth/space-bunny-alpha — closed resolved Merged PR #3813, commit 522b301a9, bumped pylint and removed the redundant too-many-lines disable; the approved change was integrated into main.
stealth/space-bunny-alpha — closed resolved Merged PR #3813 (commit 522b301a9) bumped pylint and removed the redundant disable: too-many-lines directive.
qwen/qwen3.6-35b-a3b — — Merged update bumping pylint to the latest version and removing the redundant disable: too-many-lines configuration. Approved, passed CI, and integrated into main as part of core22 architecture support.
qwen3.6-35b-a3b-mtp-q6 — — Updated pylint to the latest version and removed the redundant too-many-lines disable directive. Merged with no coverage change, supporting core22 architecture efforts.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#3712 (confidence 95%)

    Contained the broader core22 architecture work; the author noted this Pylint update was no longer strictly required after the 2.14 bump.

Related issues

Issue Project State Summary Similarity
#216 lint: remove pylint useless suppression "too-many-lines" craft-providers merged Merged in a8d5fc5: removed the obsolete pylint too-many-lines suppression after the file fell below 1,000 LOC.
85%
#66 lint: update pylint configuration craft-store merged Merged PR #66 as commit 20c7aa9, refreshing the pylint configuration without functional code changes.
81%
#291 lint: remove leftover pylint directive craft-parts merged Merged PR #291 in commit fb583a60, removing one leftover pylint directive from a single file.
80%
#164 lint: compliance with pylint-2.12.2 (CRAFT-716) craft-parts merged Merged PR #164 as 53ee6b27, updating 41 files for pylint 2.12.2 compliance; its explicit file-I/O encoding changes were later reverted in 42d91e33.
77%
#192 lint: enable pylint useless-supression, minor reformatting craft-providers merged Merged lint cleanup in craft-providers#192 via commit f644c25, enabling pylint's useless-suppression check, removing obsolete suppressions, and reformatting seven files without functional changes.
76%
#127 lint: update pylint to 2.14 craft-providers merged Merged PR #127 via commit a38cb5a, updating .pylintrc for pylint 2.14 compatibility in change 69a2c0e.
75%
#4817 style: remove pylint snapcraft merged Merged as a9badaa32, removing Pylint from lint tooling, configuration, and source suppressions after Ruff had replaced nearly all of it.
74%
#57 tests: update pylint and address new warnings craft-parts merged Merged PR #57 in commit 78560246 upgraded pylint to 2.8.2 and addressed the resulting warnings with minor test changes.
72%
#118 style: remove pylint craft-store merged Merged PR #118 as commit beb9201, removing Pylint configuration and tooling after Ruff had replaced it.
72%
#112 static: bump pylint to latest version craft-providers merged Merged #112 as bd02f17 (change b07e4f7), updating pylint to support pylint-fixme-info v1.0.3.
72%