← Back to issue list

lint: bump pylint

View original Github issue

Metadata

Project
snapcraft
Number
#3813
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged update bumping pylint to the latest version and removing the redundant disable: too-many-lines configuration. Approved, passed CI, and integrated into main as part of core22 architecture support.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Bump pylint to latest version, remove redundant `disable: too-many-lines`. Part 2 of supporting architectures for `core22`. Full code change is proposed [here](https://github.com/snapcore/snapcraft/pull/3712). This is no longer strictly required for architectures support since Claudio bumped the major version (2.13->2.14) last week. I'm still pushing it, as it's a simple update. (CRAFT-1164)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update bumping pylint to the latest version and removing the redundant disable: too-many-lines configuration. Approved, passed CI, and integrated into main as part of core22 architecture support.
qwen3.6-35b-a3b-mtp-q6 Updated pylint to the latest version and removed the redundant too-many-lines disable directive. Merged with no coverage change, supporting core22 architecture efforts.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Bumped pylint to the latest version and removed a redundant disable: too-many-lines directive. The update supports core22 architecture efforts and had no impact on code coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#66 lint: update pylint configuration craft-store merged Merged an update to the pylint configuration, removing 627 lines of outdated settings and adding 16 lines with no functional changes. Approved by a reviewer and passed all CI checks.
86%
#291 lint: remove leftover pylint directive craft-parts merged Merged a change removing a leftover pylint directive. The single-line deletion across one file received reviewer approval and was integrated after passing checks.
78%
#166 linters: re-enable pylint fixme info craft-parts merged Merged a one-line change to re-enable pylint fixme info in the linters configuration. Approved by one reviewer, passed all CI checks, and resolved with zero outstanding comments.
75%
#164 lint: compliance with pylint-2.12.2 (CRAFT-716) craft-parts merged Merged to enforce pylint 2.12.2 compliance. Approved by two reviewers. One reviewer suggested disabling a default encoding warning instead of explicitly setting it. The branch was merged with 15 unresolved comments.
75%
#57 tests: update pylint and address new warnings craft-parts merged Merged after two approvals and passing CI. Updated pylint to 2.8.2 and resolved newly introduced linting warnings in the test suite with minor code adjustments across a single file.
74%
#4073 lint: reintroduce pylint in tox snapcraft merged Merged into main following approval and passing CI checks. The change reintroduces pylint to the tox configuration, adding 15 lines and removing 1 in a single file. Code coverage remains unchanged.
74%
#118 style: remove pylint craft-store merged Merged to remove pylint from the project. Approved by one reviewer, passed CI checks, and modified two files with a net reduction of three lines.
74%
#3747 cli: disable new pylint false positive snapcraft merged Merged a change to disable a new pylint false positive in the CLI. Approved by a reviewer, passed CI and lint checks, and modified one file. The author confirmed unrelated spread failures did not impact the change.
74%
#4817 style: remove pylint snapcraft merged Merged removal of pylint configuration, fully replaced by ruff. Approved by three reviewers, passed CI checks, and modified 46 files across the codebase.
74%
#38 Install dev requirements to properly run pylint imagecraft merged Merged a single-line change to install development dependencies, enabling proper pylint execution. The change was integrated directly without reviewer comments or CI checks.
72%