← Back to issue list

lint: format with ruff and fix ruff linting errors

View original Github issue

Metadata

Project
rockcraft
Number
#264
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Ruff formatting and lint cleanup in #264 was closed unmerged after remaining unreviewed. Prerequisite #263 merged as 4abd39c2, while later Ruff adoption continued in #363.

Resolution: closed stale

Reason: PR #264 closed unmerged without reviews or recorded CI results, indicating abandonment. Its prerequisite merged separately in #263 as 4abd39c2; commit e583ec8e later replaced Black with Ruff in #363.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- REQUIRES #263

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Ruff formatting and lint cleanup in #264 was closed unmerged after remaining unreviewed. Prerequisite #263 merged as 4abd39c2, while later Ruff adoption continued in #363.
stealth/space-bunny-alpha — closed stale Ruff formatting and lint cleanup was closed unmerged after remaining unreviewed; prerequisite Ruff configuration PR #263 merged separately as 4abd39c2.
stealth/space-bunny-alpha — closed stale Ruff formatting and lint fixes in PR #264 were closed unmerged after remaining unreviewed. The required Ruff-config PR #263 was merged separately.
qwen/qwen3.6-35b-a3b — — Closed without merging. The ruff formatting and linting fixes were abandoned due to zero reviewer engagement and a pending dependency on issue #263.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The ruff formatting and linting fix was abandoned, pending dependency PR #263. No review comments were provided.

Update history

No update history recorded yet.

Related work

  • Blocked By: canonical/rockcraft#263 (confidence 100%)

    Explicit prerequisite that merged as commit 4abd39c2.

  • Superseded By: canonical/rockcraft#363 (confidence 80%)

    Later merged work removed Black in favor of Ruff in commit e583ec8e.

Related issues

Issue Project State Summary Similarity
#19 style: fix linting issues for ruff 0.12 craft-artifacts closed PR #19 was closed unmerged after prolonged inactivity; its Ruff 0.12 lint fixes were abandoned. Later PR #20 was merged as commit 04cbdc0.
83%
#33 lint: fix lint issues with newer ruff craft-archives merged PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641.
81%
#68 lint: update ruff and fix linting craft-archives merged Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67.
80%
#205 style(lint): autofix ruff 0.6.4 linting errors craft-store closed PR #205 was closed unmerged after 745 days; its Ruff 0.6.4 ARG001 autofix received no review, comments, or CI runs, and no resolving commit was recorded.
80%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
80%
#29 style(lint): fix ruff 0.6.0 linting errors craft-platforms merged Merged PR #29 as commit 399c4e0, fixing Ruff 0.6.0 lint errors and switching the pre-commit Ruff hook to rolling versions.
80%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
80%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
79%
#624 style(lint): fix ruff 0.6.0 linting errors craft-providers merged Merged as commit 823622d, fixing Ruff 0.6.0 lint errors and switching the pre-commit Ruff hook to rolling versions.
79%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
79%