← Back to issue list

pytest plugin `assert_error`

View original Github issue

Metadata

Project
craft-cli
Number
#162
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Feature request for a pytest plugin `assert_error` was implemented in #218 (dd3fe83, 2.11.0) then reverted by merged PR #311 (84df9bf) as a breaking change; 2.12.0 changelog documents its removal, deferring it to 3.0.

Resolution: closed superseded

Reason: The pytest `assert_error` method landed via merged PR #218 (commit dd3fe83) but maintainer lengau closed the issue after merging revert PR #311 (commit 84df9bf), which removed the breaking method in 2.12.0 with a recommendation to use capsys instead; the feature is deferred to the next major release.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Like the various message asserts, the pytest plugin's emitter should be able to assert that the `error` method was called and check the corresponding craft error. ### Why it needs to get done Right now there's no way to check that the correct error was sent to `emit.error`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Feature request for a pytest plugin `assert_error` was implemented in #218 (dd3fe83, 2.11.0) then reverted by merged PR #311 (84df9bf) as a breaking change; 2.12.0 changelog documents its removal, deferring it to 3.0.
stealth/space-bunny-alpha — closed superseded assert_error was added by #218, then reverted by merged #311 (84df9bf) because it broke compatibility; support is deferred to the next major release.
stealth/space-bunny-alpha — closed superseded assert_error landed in #218, then PR #311 merged as 84df9bf to restore compatibility; support was deferred to the next major release.
qwen/qwen3.6-35b-a3b — — assert_error support was implemented but reverted in PR 311 due to being an unintended breaking change. The feature is deferred to the next major release.
qwen/qwen3.6-35b-a3b — — The pytest assertion feature is being reverted as a breaking change and deferred to the next major release.
qwen/qwen3.6-35b-a3b — — The pytest plugin assert_error feature was reverted in PR 311 due to an unintended breaking change. The functionality remains valid but is deferred to the next major release.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-cli#311 (confidence 98%)

    Merged revert PR removing assert_error as an unintentional breaking change.

  • Likely Fixed By: canonical/craft-cli#218 (confidence 95%)

    Original PR adding the pytest assert_error method, merged as dd3fe83 and then reverted.

Related issues

Issue Project State Summary Similarity
#218 feat(pytest): add an assert_error plugin method craft-cli merged Merged as dd3fe83 to add pytest assert_error for #162, but #311 reverted it in 84df9bf due to an unintended breaking change; release 2.12.0 documents its removal.
83%
#311 fix(pytest): revert "add an assert_error plugin method" craft-cli merged Merged #311 (84df9bf) reverted #218, removing the breaking pytest assert_error plugin added in 2.11.0. Craft-cli 2.12.0 recommends capsys instead; support was deferred to 3.0.
72%