← Back to issue list

feat(pytest): add an assert_error plugin method

View original Github issue

Metadata

Project
craft-cli
Number
#218
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as dd3fe83 to add pytest assert_error for #162, but #311 reverted it in 84df9bf due to an unintended breaking change; release 2.12.0 documents its removal.

Resolution: closed superseded

Reason: PR #218 was merged in dd3fe83, but revert PR #311 removed the feature in 84df9bf after its addition in 2.11.0. Support was deferred to a future major release.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #162 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Merged as dd3fe83 to add pytest assert_error for #162, but #311 reverted it in 84df9bf due to an unintended breaking change; release 2.12.0 documents its removal.
stealth/space-bunny-alpha — closed resolved PR #218 merged as dd3fe83, adding pytest assert_error, but #311 reverted it in 84df9bf due to an unintended breaking change; the feature is deferred to the next major release.
qwen/qwen3.6-35b-a3b — — Merged after adding an assert_error pytest plugin method to fix issue #162. Approved by two reviewers, passed CI, and resolved with zero open comments. The update modifies two files, adding 53 lines and removing 5.

Update history

No update history recorded yet.

Related work

  • Superseded By: craft-cli#311 (confidence 100%)

    Merged revert that removed assert_error because it caused a compatibility break.

  • Related To: craft-cli#162 (confidence 100%)

    The feature request that PR #218 originally stated it fixed.

Related issues

Issue Project State Summary Similarity
#162 pytest plugin `assert_error` craft-cli closed Feature request for a pytest plugin `assert_error` was implemented in #218 (dd3fe83, 2.11.0) then reverted by merged PR #311 (84df9bf) as a breaking change; 2.12.0 changelog documents its removal, deferring it to 3.0.
83%
#311 fix(pytest): revert "add an assert_error plugin method" craft-cli merged Merged #311 (84df9bf) reverted #218, removing the breaking pytest assert_error plugin added in 2.11.0. Craft-cli 2.12.0 recommends capsys instead; support was deferred to 3.0.
79%