feat: add secrets API
Metadata
Current evaluation
Merged the secrets API feature, adding Emitter.set_secrets to mask sensitive strings across all CLI outputs. Approved by two reviewers, passed CI checks, and achieved 100% diff coverage. Resolves issue 184.
Suggested action: —
No scores available.
Issue body
The public API consists of a single method, `Emitter.set_secrets()`, that receives a list of strings and causes said strings to be masked by "*****" in every output generated by the emitter's printer. This includes regular emitter messages, messages generated by log calls, spinner, progress bar and the "streaming brief" prefix.
Fixes #184
(CRAFT-2107)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged the secrets API feature, adding Emitter.set_secrets to mask sensitive strings across all CLI outputs. Approved by two reviewers, passed CI checks, and achieved 100% diff coverage. Resolves issue 184. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to main, introducing Emitter.set_secrets() to mask sensitive strings in all emitter output. Resolves #184 with 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #483 feat(secrets): support for 'basic' secrets | fetch-service | merged | Merged feature adding support for basic secrets. Approved by three reviewers, passed all CI checks, and modified 14 files with 240 additions and 14 deletions. | |
| #104 feat: support build-secrets in managed-mode | craft-application | merged | Merged into main. Implements build-secrets support in managed-mode by encoding secrets into the host-application environment for the managed instance to decode and re-render. Approved by two reviewers, passed CI, and achieved 100% diff coverage. | |
| #378 feat: enable build-secrets | rockcraft | merged | Merged to enable build-secrets. Approved by two reviewers, the update modifies six files (+48/-4). The target branch was adjusted to feature/build-secrets before final merge. | |
| #657 feat!(secrets): remove secrets | craft-application | merged | Merged after two approvals and passing CI. The change removes built-in secrets functionality, deleting 595 lines across eight files. Applications can instead implement the prototype secrets service if needed. |