← Back to issue list

fix(build): install system packages when running `make setup`

View original Github issue

Metadata

Project
craft-cli
Number
#367
Type
pull request
State
merged
Author
jahn-junior
Labels
Created
Updated
Closed

Current evaluation

Merged a build fix installing system packages during make setup. Approved by two reviewers with all CI checks passing. The single-file change (+19/-10 lines) ensures build dependencies are correctly provisioned.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a build fix installing system packages during make setup. Approved by two reviewers with all CI checks passing. The single-file change (+19/-10 lines) ensures build dependencies are correctly provisioned.
qwen3.6-35b-a3b-mtp-q6 Merged a build fix that automatically installs required system packages when running make setup. This resolves missing dependency errors and streamlines the initial project configuration process.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5645 fix: install system packages when running `make setup` snapcraft merged Merged a fix updating make setup to install required system packages. Approved by two reviewers, passed CI, and merged by maintainer jahn-junior with a 19-line addition and 10-line removal across one file.
87%
#418 fix: install system packages during setup starbase merged Merged after approval and passing CI checks. The update configures make setup to run all setup targets, ensuring system packages are installed. A reviewer flagged potential dependency conflicts, but the changes were successfully integrated.
84%
#825 fix: install system packages when running `make setup` craft-application merged Merged a fix updating make setup to install required system packages by cherry-picking Starbase commits. Approved by two reviewers with all CI checks passing, the single-file change resolves package installation issues during the build setup process.
84%
#929 fix: install system packages when running `make setup` rockcraft merged Merged a fix that updates make setup to install system packages by cherry-picking relevant Starbase commits. Approved by two reviewers and passed CI checks except one unrelated snap test.
81%
#341 fix(make): depend on build deps during setup starbase merged Merged after reviewer approval and passing CI. The change updates the Makefile to correctly declare build dependencies during the setup phase, modifying a single line.
80%
#6133 build: fix docs-install target snapcraft merged Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI.
76%
#2392 fix: install system packages when running `make setup` charmcraft merged Merged by jahn-junior after two approvals. Updates make setup to install system packages by cherry-picking Starbase commits. Accepted despite failing snap tests on Ubuntu 20.04 and 22.04.
75%
#2137 fix(build): fix build dependencies and CI charmcraft merged Merged by maintainer lengau after approval from two reviewers. Resolved build dependency and CI configuration issues across three files, adding 51 lines and removing 13.
75%
#563 fix(build): collapse docs-install logs under parent targets starbase merged Merged a Makefile update that collapses docs-install log output under parent targets to prevent CI log clutter. Approved by reviewers, passed all CI checks, and resolves the logging issue.
72%
#491 fix(build): use correct autobuild command starbase merged Merged a one-line fix correcting the autobuild command. Approved by two reviewers and passed all CI checks, resolving the build configuration issue.
71%