← Back to issue list

fix: install system packages when running `make setup`

View original Github issue

Metadata

Project
rockcraft
Number
#929
Type
pull request
State
merged
Author
jahn-junior
Labels
Created
Updated
Closed

Current evaluation

Merged a fix that updates make setup to install system packages by cherry-picking relevant Starbase commits. Approved by two reviewers and passed CI checks except one unrelated snap test.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? --- Cherry-picks the relevant Starbase commits to update `make setup`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix that updates make setup to install system packages by cherry-picking relevant Starbase commits. Approved by two reviewers and passed CI checks except one unrelated snap test.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to install system packages during make setup by cherry-picking relevant Starbase commits. The update ensures proper dependency installation for the build environment.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to install system packages when running make setup. Cherry-picks relevant Starbase commits to update the setup target and ensure proper dependency installation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#825 fix: install system packages when running `make setup` craft-application merged Merged a fix updating make setup to install required system packages by cherry-picking Starbase commits. Approved by two reviewers with all CI checks passing, the single-file change resolves package installation issues during the build setup process.
94%
#2392 fix: install system packages when running `make setup` charmcraft merged Merged by jahn-junior after two approvals. Updates make setup to install system packages by cherry-picking Starbase commits. Accepted despite failing snap tests on Ubuntu 20.04 and 22.04.
92%
#5645 fix: install system packages when running `make setup` snapcraft merged Merged a fix updating make setup to install required system packages. Approved by two reviewers, passed CI, and merged by maintainer jahn-junior with a 19-line addition and 10-line removal across one file.
83%
#418 fix: install system packages during setup starbase merged Merged after approval and passing CI checks. The update configures make setup to run all setup targets, ensuring system packages are installed. A reviewer flagged potential dependency conflicts, but the changes were successfully integrated.
81%
#367 fix(build): install system packages when running `make setup` craft-cli merged Merged a build fix installing system packages during make setup. Approved by two reviewers with all CI checks passing. The single-file change (+19/-10 lines) ensures build dependencies are correctly provisioned.
81%