← Back to issue list

fix: install system packages when running `make setup`

View original Github issue

Metadata

Project
rockcraft
Number
#929
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/rockcraft#929, updating make setup to install required system packages through cherry-picked Starbase changes.

Resolution: closed resolved

Reason: PR #929 was merged after approval by two reviewers. It ported the relevant Starbase setup changes so make setup installs required system packages.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? --- Cherry-picks the relevant Starbase commits to update `make setup`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#929, updating make setup to install required system packages through cherry-picked Starbase changes.
stealth/space-bunny-alpha — closed resolved Merged #929 updates make setup to install system packages by cherry-picking relevant Starbase changes.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2392, updating make setup to install system packages by cherry-picking relevant Starbase commits.
qwen/qwen3.6-35b-a3b — — Merged a fix that updates make setup to install system packages by cherry-picking relevant Starbase commits. Approved by two reviewers and passed CI checks except one unrelated snap test.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to install system packages during make setup by cherry-picking relevant Starbase commits. The update ensures proper dependency installation for the build environment.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2392 (confidence 90%)

    Previously merged Charmcraft change whose Starbase updates were ported here.

  • Related To: canonical/starbase#418 (confidence 90%)

    Upstream Starbase PR titled fix: install system packages during setup.

Related issues

Issue Project State Summary Similarity
#825 fix: install system packages when running `make setup` craft-application merged Merged PR #825 in commit d9e7b996, updating `make setup` to install required system packages via cherry-picked Starbase changes.
86%
#2392 fix: install system packages when running `make setup` charmcraft merged Merged PR #2392 (724cf55b) updated make setup to install required system packages by cherry-picking relevant Starbase changes.
85%
#418 fix: install system packages during setup starbase merged Merged in canonical/starbase#418 (df0ff64), updating make setup to run all setup-* targets and install required system packages.
83%
#5645 fix: install system packages when running `make setup` snapcraft merged Merged PR #5645 as commit 5a14b3361, fixing make setup to install required system packages.
74%
#501 fix: help formatting when running `make -f common.mk` starbase merged Merged PR canonical/starbase#501 (commit 0344506) fixing help output formatting when running `make -f common.mk`; upported from canonical/rockcraft#1105. Approved by 2 reviewers, all CI checks passed.
73%
#367 fix(build): install system packages when running `make setup` craft-cli merged Merged PR #367 to make `make setup` install required system packages; two reviewers approved it and all listed CI checks passed.
70%