fix: install system packages when running `make setup`
Metadata
Current evaluation
Merged a fix updating make setup to install required system packages. Approved by two reviewers, passed CI, and merged by maintainer jahn-junior with a 19-line addition and 10-line removal across one file.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix updating make setup to install required system packages. Approved by two reviewers, passed CI, and merged by maintainer jahn-junior with a 19-line addition and 10-line removal across one file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that installs required system packages during make setup. The maintainer-authored change passed all lint and test validations and was integrated directly without review comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that automatically installs system packages when running make setup. The change was approved and integrated into the main branch without additional comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #367 fix(build): install system packages when running `make setup` | craft-cli | merged | Merged a build fix installing system packages during make setup. Approved by two reviewers with all CI checks passing. The single-file change (+19/-10 lines) ensures build dependencies are correctly provisioned. | |
| #825 fix: install system packages when running `make setup` | craft-application | merged | Merged a fix updating make setup to install required system packages by cherry-picking Starbase commits. Approved by two reviewers with all CI checks passing, the single-file change resolves package installation issues during the build setup process. | |
| #418 fix: install system packages during setup | starbase | merged | Merged after approval and passing CI checks. The update configures make setup to run all setup targets, ensuring system packages are installed. A reviewer flagged potential dependency conflicts, but the changes were successfully integrated. | |
| #2392 fix: install system packages when running `make setup` | charmcraft | merged | Merged by jahn-junior after two approvals. Updates make setup to install system packages by cherry-picking Starbase commits. Accepted despite failing snap tests on Ubuntu 20.04 and 22.04. | |
| #929 fix: install system packages when running `make setup` | rockcraft | merged | Merged a fix that updates make setup to install system packages by cherry-picking relevant Starbase commits. Approved by two reviewers and passed CI checks except one unrelated snap test. | |
| #341 fix(make): depend on build deps during setup | starbase | merged | Merged after reviewer approval and passing CI. The change updates the Makefile to correctly declare build dependencies during the setup phase, modifying a single line. | |
| #6133 build: fix docs-install target | snapcraft | merged | Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI. |