← Back to issue list

fix: install system packages when running `make setup`

View original Github issue

Metadata

Project
snapcraft
Number
#5645
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5645 as commit 5a14b3361, fixing make setup to install required system packages.

Resolution: closed resolved

Reason: PR #5645 was approved and merged as commit 5a14b3361. Its Makefile change ensures make setup installs missing system packages.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5645 as commit 5a14b3361, fixing make setup to install required system packages.
stealth/space-bunny-alpha — closed resolved Merged PR #5645 fixed `make setup` to install required system packages in commit 5a14b3361.
stealth/space-bunny-alpha — closed resolved Merged #5645 into main, making make setup install required system packages. Resolution commit: 5a14b3361.
stealth/space-bunny-alpha — closed resolved Merged PR #5645 via commit 5a14b3361, fixing make setup to install required system packages.
stealth/space-bunny-alpha — closed resolved Merged PR #5645 fixed `make setup` to install required system packages; resolution landed in commit 5a14b3361.
stealth/space-bunny-alpha — closed resolved Merged fix makes make setup install system packages; core build, test, lint, security, and publish checks passed, but Ubuntu 22.04 and store integration jobs failed.
qwen/qwen3.6-35b-a3b — — Merged a fix updating make setup to install required system packages. Approved by two reviewers, passed CI, and merged by maintainer jahn-junior with a 19-line addition and 10-line removal across one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that installs required system packages during make setup. The maintainer-authored change passed all lint and test validations and was integrated directly without review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#825 fix: install system packages when running `make setup` craft-application merged Merged PR #825 in commit d9e7b996, updating `make setup` to install required system packages via cherry-picked Starbase changes.
85%
#2392 fix: install system packages when running `make setup` charmcraft merged Merged PR #2392 (724cf55b) updated make setup to install required system packages by cherry-picking relevant Starbase changes.
82%
#367 fix(build): install system packages when running `make setup` craft-cli merged Merged PR #367 to make `make setup` install required system packages; two reviewers approved it and all listed CI checks passed.
81%
#418 fix: install system packages during setup starbase merged Merged in canonical/starbase#418 (df0ff64), updating make setup to run all setup-* targets and install required system packages.
74%
#929 fix: install system packages when running `make setup` rockcraft merged Merged in canonical/rockcraft#929, updating make setup to install required system packages through cherry-picked Starbase changes.
74%