← Back to issue list

feat: allow the app to select the grammar variant

View original Github issue

Metadata

Project
craft-grammar
Number
#138
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged implementation allowing the app to select grammar variants. Resolves #126 and CRAFT-4745. Approved by two reviewers, passed all CI checks, and modified four files with a net addition of 46 lines.

Suggested action:

No scores available.

Issue body

Fixes #126 CRAFT-4745 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged implementation allowing the app to select grammar variants. Resolves #126 and CRAFT-4745. Approved by two reviewers, passed all CI checks, and modified four files with a net addition of 46 lines.
qwen3.6-35b-a3b-mtp-q6 Merged feature enabling the application to select a grammar variant. Resolves issue #126 and CRAFT-4745. Code passed linting and testing checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#150 feat: evaluate project using grammar rules craft-application merged Merged after approval and passing CI. Implements dual grammar evaluation to transparently resolve build plans and target architectures. Minor coverage gaps were noted but did not block the merge.
72%
#296 feat(grammar): enable grammar-aware for all PartSpec craft-application merged Merged to enable grammar-aware syntax for all PartSpec. Approved by three reviewers, the update adds - on X to Y: values support across five files (+531/-38 lines) and depends on craft-grammar PR #17.
71%