Improve typing and linting
Metadata
Current evaluation
Strict Pyright checks and typing fixes were merged in canonical/craft-parts#1294 at bb62329e, addressing suppressions and strict-mode requirements.
Resolution: closed resolved
Reason: PR canonical/craft-parts#1294 was merged with commit bb62329e, enabling strict Pyright checking and fixing typing errors instead of suppressing them.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
Currently, craft-parts has minimized use of pyright and numerous noqa's. A comb through the repository should be done to fix errors instead of silencing them and pyright should be set to "strict" mode.
### Why it needs to get done
Linting makes our lives easier.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Strict Pyright checks and typing fixes were merged in canonical/craft-parts#1294 at bb62329e, addressing suppressions and strict-mode requirements. | |
| stealth/space-bunny-alpha | — | closed resolved | Strict Pyright checking and related type-error fixes were merged in canonical/craft-parts#1294 (bb62329e), addressing the issue's typing goals. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned. Closed without implementation or associated pull requests. No code changes were made, and the task appears to have been migrated to Jira for tracking. | |
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
9
Staleness:
85
Complexity:
55
Confidence:
90
Support Request:
5
|
close stale | Maintainer request to fix type errors instead of silencing with noqa and enable pyright strict mode. Core request completed: PR #1294 enabled strict pyright and follow-ups removed unnecessary noqa's. Inactive and closable. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
45
Confidence:
80
Support Request:
5
|
keep open | Task to replace pyright noqa comments with actual fixes and enable strict mode. Triaged by a maintainer but inactive for over a year with no progress or discussion. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
90
Complexity:
40
Confidence:
80
Support Request:
5
|
close stale | Issue requests fixing pyright errors and enabling strict mode instead of using noqa comments. Triaged by a maintainer but inactive for over 10 months with no progress or discussion. |
Update history
| Date | Change |
|---|---|
| closed |
Related work
-
Likely Fixed By:
canonical/craft-parts#1294
(confidence 98%)
The merged PR implemented strict Pyright checks and related type-error fixes.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #177 linting: address pyright issues | craft-parts | merged | Merged in craft-parts#177: updated type declarations for Pyright 1.1.225, added Optional for arguments that may be None, and fixed callback annotation typos. | |
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files. | |
| #90 many: address new linter warnings (CRAFT-364) | craft-parts | merged | Merged in canonical/craft-parts#90 (commit 23f38957), resolving CRAFT-364 by fixing or suppressing new mypy and pylint warnings. |