Improve typing and linting
Metadata
Current evaluation
Maintainer request to fix type errors instead of silencing with noqa and enable pyright strict mode. Core request completed: PR #1294 enabled strict pyright and follow-ups removed unnecessary noqa's. Inactive and closable.
Suggested action: close stale
Reason: The issue's core ask is implemented: PR #1294 'style: enable strict type checking with pyright' was merged and pyproject.toml now has [tool.pyright] strict = ["craft_parts"], and follow-up commits ('style: add easy noqa fixes (#1340)', 'style: drop outdated noqa's', 'linting: remove unnecessary noqa lines') addressed the noqa comb-through. The issue has had no activity for 361 days beyond an autogenerated Jira-sync bot comment, so it is both inactive and no longer applicable.
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
9.0
Staleness:
85
Complexity:
55
Confidence:
90
Support Request:
5
|
close stale | Maintainer request to fix type errors instead of silencing with noqa and enable pyright strict mode. Core request completed: PR #1294 enabled strict pyright and follow-ups removed unnecessary noqa's. Inactive and closable. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
45
Confidence:
80
Support Request:
5
|
keep open | Task to replace pyright noqa comments with actual fixes and enable strict mode. Triaged by a maintainer but inactive for over a year with no progress or discussion. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
90
Complexity:
40
Confidence:
80
Support Request:
5
|
close stale | Issue requests fixing pyright errors and enabling strict mode instead of using noqa comments. Triaged by a maintainer but inactive for over 10 months with no progress or discussion. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
75
Complexity:
45
Confidence:
85
Support Request:
0
|
keep open | Replace pyright noqa comments with actual fixes and enable strict mode to improve typing and linting. Currently triaged and awaiting assignment after 287 days of inactivity. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
craft-parts#1294
(confidence 90%)
Merged PR 'style: enable strict type checking with pyright'; current pyproject.toml confirms [tool.pyright] strict = ["craft_parts"], directly satisfying the issue's main request.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged PR enabling strict type checking with pyright. All resulting type errors were resolved, improving the project's typing and linting status. The change passed CI checks and was approved, successfully integrating stricter type safety. |