style(type): make `ty` happy with the `craft_parts` directory
Metadata
Current evaluation
Merged #1267 in commit 2ca02baf, applying type/style fixes across five craft_parts files with all CI checks passing; remaining test-directory typing work stayed in astral-sh/ty#445.
Resolution: closed resolved
Reason: PR #1267 merged as commit 2ca02baf after two approvals and passing CI. It resolved the targeted craft_parts typing cleanup, while related test-directory issues remained tracked in astral-sh/ty#445.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The tests directory still has many issues mentioned here: https://github.com/astral-sh/ty/issues/445
But this at least gets us started.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1267 in commit 2ca02baf, applying type/style fixes across five craft_parts files with all CI checks passing; remaining test-directory typing work stayed in astral-sh/ty#445. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1267 as commit 2ca02baf, applying style and type fixes across five craft_parts files; remaining test-directory cleanup is tracked in astral-sh/ty#445. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1267 (commit 2ca02baf) after two approvals and passing CI, applying style/type fixes across five files in craft_parts; remaining test typing issues are tracked in astral-sh/ty#445. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and passing CI. Applied style and type fixes to the craft_parts directory to satisfy the ty linter, modifying five files with minor adjustments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer pull request applying style and type fixes to the craft_parts directory to satisfy the ty linter. This addresses initial test directory compliance issues and advances project-wide linting goals. |
Update history
No update history recorded yet.
Related work
-
Related To:
ty#445
(confidence 95%)
The PR cites this upstream issue for unresolved typing problems in the tests directory.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #485 style: ty 0.0.79 | craft-cli | closed | Merged into main: a +2/-2 line one-file style fix for the new error reported by the ty 0.0.79 type checker, by maintainer mr-cal; review approved, all 25 CI checks green. Ty was later bumped to 0.0.82 in craft-parts#1727. | |
| #139 style(type): fix typing issues found by ty | craft-platforms | merged | Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553. | |
| #446 style(lint): fix typing for ty update | craft-cli | merged | Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files. |