style(type): make `ty` happy with the `craft_parts` directory
Metadata
Current evaluation
Merged after two approvals and passing CI. Applied style and type fixes to the craft_parts directory to satisfy the ty linter, modifying five files with minor adjustments.
Suggested action: —
No scores available.
Issue body
The tests directory still has many issues mentioned here: https://github.com/astral-sh/ty/issues/445
But this at least gets us started.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and passing CI. Applied style and type fixes to the craft_parts directory to satisfy the ty linter, modifying five files with minor adjustments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer pull request applying style and type fixes to the craft_parts directory to satisfy the ty linter. This addresses initial test directory compliance issues and advances project-wide linting goals. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1084 style: replace mypy and pyright with ty | craft-application | merged | Merged a squashed pull request replacing mypy and pyright with ty for type checking across 70 files. Approved by two reviewers with all CI checks passing, the change streamlines the linting configuration for craft-app 7. | |
| #421 style: ty | craft-cli | merged | Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420. | |
| #446 style(lint): fix typing for ty update | craft-cli | merged | Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated. | |
| #407 style(types): enable type checking with ty | craft-cli | merged | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. | |
| #2726 style: switch type checking to ty | charmcraft | merged | Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files. | |
| #6247 style: go all-in on ty | snapcraft | merged | Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139. | |
| #242 style: fix ty linting error | craft-platforms | merged | Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation. | |
| #1126 style: fix ty errors | craft-application | merged | Merged a style update to replace pydantic with ty for type checking, leveraging ty's new Pydantic support. Approved by reviewers, passed CI checks, and integrated into the codebase. | |
| #1698 style: ty | craft-parts | merged | Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review. |