← Back to issue list

style(lint): fix typing for ty update

View original Github issue

Metadata

Project
craft-cli
Number
#446
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files.

Resolution: closed resolved

Reason: The approved pull request was merged into the main branch as commit 75ec620.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files.
stealth/space-bunny-alpha — closed resolved Merged PR #446 in commit 75ec620, updating typing for the ty linter with minor style changes across three files.
qwen/qwen3.6-35b-a3b — — Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
84%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
80%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
77%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
76%
#1126 style: fix ty errors craft-application merged Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.
76%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
75%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
74%
#335 fix(lint): suppress ty imagecraft merged Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed.
74%
#902 style: add type ignores craft-providers merged Merged #902 added targeted ty type-ignore comments across three files, unblocking lint CI.
74%
#20 style: fix linting issues craft-artifacts merged Merged PR #20 via commit 04cbdc0, applying style-only lint fixes across four files (+11/-5); both reviews approved and all CI checks passed.
73%