← Back to issue list

WIP: Ruby plugin

View original Github issue

Metadata

Project
craft-parts
Number
#1394
Type
pull request
State
closed
Author
steinbro
Labels
—
Created
Updated
Closed

Current evaluation

WIP Ruby plugin PR closed unmerged; maintainer noted it was superseded by properly named PR #1395 ("feat: add ruby plugin", merged as commit 4d72d5a8), which fixed #338 and replaced abandoned #341.

Resolution: closed superseded

Reason: steinbro closed this PR with the comment "Superseded by #1395", noting it violated branch naming conventions. PR #1395 was merged as commit 4d72d5a8, adding the Ruby plugin with a reusable ruby-deps part, tests and docs, resolving #338 and superseding the stale #341.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes #338. The goal is to update the abandoned PR #341 as follows: 1. Don't recompile Ruby every time, i.e. allow for a `ruby-deps` part that can be shared by other parts 2. Add tests 3. Add docs

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded WIP Ruby plugin PR closed unmerged; maintainer noted it was superseded by properly named PR #1395 ("feat: add ruby plugin", merged as commit 4d72d5a8), which fixed #338 and replaced abandoned #341.
stealth/space-bunny-alpha — closed superseded Closed unmerged because its branch name unintentionally created a protected branch. Ruby plugin work resumed in #1395 and was merged as commit 4d72d5a8.
stealth/space-bunny-alpha — closed superseded Ruby plugin WIP closed unmerged as superseded by canonical/craft-parts#1395, which added a shared ruby-deps part, tests, docs, and mruby-based builds.
qwen/qwen3.6-35b-a3b — — Superseded by PR #1395. The Ruby plugin branch was closed because its naming convention accidentally created a protected branch. The replacement PR implements the shared ruby-deps part, tests, and documentation originally requested.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #1395. The Ruby plugin was abandoned due to improper branch naming that created an unintentionally protected branch. The replacement PR implements the shared ruby-deps part, tests, and documentation.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#1395 (confidence 99%)

    Explicitly cited in the closing comment; merged as commit 4d72d5a8 and delivered the same Ruby plugin work

  • Related To: canonical/craft-parts#338 (confidence 95%)

    The issue this WIP PR set out to fix (Fixes #338); closed by the merge of #1395

  • Superseded By: canonical/craft-parts#341 (confidence 88%)

    Abandoned earlier attempt at the Ruby plugin that #1394/#1395 replaced; #341 closed as stale

  • Likely Fixed By: craft-parts#1395 (confidence 85%)

    Follow-up fixes df9bfb48 (#1414) and 50936fa4 (#1440) further polished the Ruby plugin delivered by the merging PR

Related issues

Issue Project State Summary Similarity
#341 (WIP) add Ruby plugin craft-parts closed Closed unmerged as stale on 2025-01-15; Ruby support was later added independently by merged PR #1395 in commit 4d72d5a8.
89%
#1365 Add Ruby Plugin snapcraft closed Closed unmerged; the Ruby plugin was later delivered by merged PR #1544 in commits 4f87398b0 and 1f28e8ece.
82%
#1395 feat: add ruby plugin craft-parts merged Merged Ruby plugin support in #1395 (commit 4d72d5a8), adding reusable ruby-deps, tests and docs; resolved #338 and superseded abandoned #341.
76%
#1399 ruby plugin: new plugin snapcraft closed Superseded: closed in favor of #1544, which re-landed the Ruby plugin plus unit tests (commits 4f87398b0, 1f28e8ece) after reviewers blocked #1399 for lacking unit tests.
71%
#1702838 Feature Request: ruby plugin snapcraft (launchpad) closed Ruby plugin support shipped via merged PR #1544 and Snapcraft 8.14; earlier PR #1365 closed unmerged.
71%