fix(partitions): allow plus signs in partition names
Metadata
Current evaluation
Approved changes allowing plus signs in partition names were closed and consolidated into pull request #1612 rather than merged directly.
Suggested action: —
No scores available.
Issue body
## Summary
Allow `+` in partition names so Debian package names can be used as Debcraft partitions.
This keeps partition segment validation strict: `+` is allowed inside a segment, but not at the beginning or end of a segment. It also treats `+` like `-` and `/` when detecting partition environment variable name conflicts.
Fixes #1593.
## Tests
- `python -m pytest -q tests/unit/utils/test_partition_utils.py tests/unit/utils/test_path_utils.py tests/unit/features/partitions/test_parts.py -rs`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Approved changes allowing plus signs in partition names were closed and consolidated into pull request #1612 rather than merged directly. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
35
Complexity:
15
Confidence:
90
|
needs review | Allows plus signs in partition names for Debian package compatibility. Updates validation and environment variable conflict detection. PR is approved, mergeable, and awaiting maintainer merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1593 Allow the + character in partition names | craft-parts | closed | Partition name validation was updated to permit the plus character, enabling Debian package compatibility. The change was merged and fixed in pull request #1612. | |
| #1612 feat: allow the plus sign in partition names | craft-parts | merged | Merged. Enables the plus sign in partition names to support valid .deb package naming in Debcraft. Approved by two reviewers, passed all CI checks, and resolves CRAFT-5183. | |
| #1002 feat: Allow slashes in partition names | craft-parts | merged | Merged to allow slashes in partition names, resolving issue #999. Approved by two reviewers with a +146/-85 line diff across eight files. Changelog entry added for the automated release pipeline. | |
| #600 feat(partitions): handle namespaced partitions in utils | craft-parts | merged | Merged following two reviewer approvals and passing CI. Updates utility functions to handle namespaced partitions across eight files (+229/-72 lines). Resolves #596 and CRAFT-2303. | |
| #652 feat(partitions): clean partition directories | craft-parts | merged | Merged changes cleaning partition directories when the partitions feature is enabled. Approved by two reviewers, passed CI, and resolves issue #634. | |
| #800 feat: allow hyphens in partition names | craft-parts | merged | Merged to allow hyphens in partition names. Approved by two reviewers, the change updates five files with 85 additions and 51 deletions, resolving CRAFT-3031. |