fix(partitions): allow plus signs in partition names
Metadata
Current evaluation
Closed unmerged after its plus-sign partition-name support was consolidated into merged PR #1612, committed as 5d5b792a.
Resolution: closed superseded
Reason: Maintainer cmatsuoka stated that its changes were consolidated in #1612. That replacement PR was merged as commit 5d5b792a, allowing “+” in partition names and closing #1593.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
Allow `+` in partition names so Debian package names can be used as Debcraft partitions.
This keeps partition segment validation strict: `+` is allowed inside a segment, but not at the beginning or end of a segment. It also treats `+` like `-` and `/` when detecting partition environment variable name conflicts.
Fixes #1593.
## Tests
- `python -m pytest -q tests/unit/utils/test_partition_utils.py tests/unit/utils/test_path_utils.py tests/unit/features/partitions/test_parts.py -rs`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after its plus-sign partition-name support was consolidated into merged PR #1612, committed as 5d5b792a. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; its approved support for '+' partition names was consolidated into canonical/craft-parts#1612, which was merged. | |
| qwen/qwen3.6-35b-a3b | — | — | Approved changes allowing plus signs in partition names were closed and consolidated into pull request #1612 rather than merged directly. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
craft-parts#1612
(confidence 100%)
Merged replacement PR containing the consolidated implementation.
-
Likely Fixed By:
craft-parts#1593
(confidence 100%)
Original feature issue requesting plus signs in partition names; closed by #1612.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1612 feat: allow the plus sign in partition names | craft-parts | merged | Merged PR #1612 as commit 5d5b792a, expanding partition-name validation to permit plus signs used by .deb package names. | |
| #1593 Allow the + character in partition names | craft-parts | closed | Partition-name validation now permits “+” for valid Debian package names; fixed by merged PR canonical/craft-parts#1612 (commit 5d5b792a). | |
| #600 feat(partitions): handle namespaced partitions in utils | craft-parts | merged | Merged into main in commit f387afa5 (PR #600), adding namespaced-partition handling to four partition utilities and resolving craft-parts#596. | |
| #801 fix: partitions break when using special characters | craft-parts | merged | Merged PR #801 fixed CRAFT-3031 lifecycle failures for partition names containing numbers and hyphens; merged as commit ceaf4cda. | |
| #607 fix(partitions): use base prime dir for getting primed stage packages | craft-parts | closed | Closed unmerged and superseded by the namespaced-partition work merged in #627 via commit 9fe38d11. |