← Back to issue list

fix: partitions break when using special characters

View original Github issue

Metadata

Project
craft-parts
Number
#801
Type
pull request
State
merged
Author
mattculler
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #801 fixed CRAFT-3031 lifecycle failures for partition names containing numbers and hyphens; merged as commit ceaf4cda.

Resolution: closed resolved

Reason: The approved PR was merged into the main branch as commit ceaf4cda, correcting partition work-path handling during lifecycle steps.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Partitions with numbers and hyphens can currently be added, but once you get into lifecycle steps the process will fail strangely - craft-parts thinks paths like `(partition-name1)` are normal paths. (CRAFT-3031)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #801 fixed CRAFT-3031 lifecycle failures for partition names containing numbers and hyphens; merged as commit ceaf4cda.
stealth/space-bunny-alpha — closed resolved Merged PR #801 fixed CRAFT-3031 by correctly handling partition names containing numbers and hyphens during lifecycle steps (commit ceaf4cda).
qwen/qwen3.6-35b-a3b — — Merged fix for CRAFT-3031 resolving lifecycle failures from misinterpreted paths in partitions with numbers and hyphens. Approved by two reviewers, the change updates four files to correctly handle special characters.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix resolving partition path parsing failures when using numbers and hyphens. The update corrects craft-parts misinterpreting special character paths during lifecycle steps, addressing CRAFT-3031.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#800 feat: allow hyphens in partition names craft-parts merged Merged PR #800 as commit 184d5142, adding support for hyphens in partition names for CRAFT-3031.
80%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged into main in commit f387afa5 (PR #600), adding namespaced-partition handling to four partition utilities and resolving craft-parts#596.
76%
#599 feat(partitions): validate namespaced partitions craft-parts merged Merged PR #599 as commit 06a5f999, adding namespaced partition validation during LifecycleManager initialization and fixing #595 (CRAFT-2032).
75%
#497 partitions: add utility to make partition compatible filepaths craft-parts merged Merged #497, adding a utility that converts filepaths into partition-compatible paths for CRAFT-1845; landed as commit 20e994f8.
74%
#790 feat: allow numbers in partition names and namespaces craft-parts merged Merged PR #790 (commit b2128938) relaxes partition/namespace name validation to allow numbers; unblocked LP#2069783 (CRAFT-3043). Follow-up for hyphens filed as #789, fixed later by #800.
74%
#1002 feat: Allow slashes in partition names craft-parts merged Merged as c2e41898, allowing slashes in partition names and fixing #999 (CRAFT-4064).
74%
#652 feat(partitions): clean partition directories craft-parts merged Merged #652 via commit 797109e8, adding partition-directory cleanup when partitions are enabled and fixing #634 (CRAFT-2417).
74%
#672 Using partitions introduces a breaking change craft-parts closed Partition path/working-directory breakage was fixed by the top-level redesign in craft-parts#620, merged via PR #684 (188d9166).
73%
#1591 fix(errors): generalize partition usage resolution craft-parts merged Merged PR #1591 (commit 5d96832f) generalized PartitionUsageError guidance for all invalid partition usage, fixed #836, and shipped in craft-parts 2.36.0.
72%
#602 feat(partitions): create envvars for namespaced partitions craft-parts merged Merged PR #602 (commit a8615eec) adds CRAFT_<PARTITION>_STAGE/PRIME env vars for namespaced partitions, drops #600's xfails, and fixes #597.
72%