← Back to issue list

fix: partitions break when using special characters

View original Github issue

Metadata

Project
craft-parts
Number
#801
Type
pull request
State
merged
Author
mattculler
Labels
Created
Updated
Closed

Current evaluation

Merged fix for CRAFT-3031 resolving lifecycle failures from misinterpreted paths in partitions with numbers and hyphens. Approved by two reviewers, the change updates four files to correctly handle special characters.

Suggested action:

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Partitions with numbers and hyphens can currently be added, but once you get into lifecycle steps the process will fail strangely - craft-parts thinks paths like `(partition-name1)` are normal paths. (CRAFT-3031)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for CRAFT-3031 resolving lifecycle failures from misinterpreted paths in partitions with numbers and hyphens. Approved by two reviewers, the change updates four files to correctly handle special characters.
qwen3.6-35b-a3b-mtp-q6 Merged fix resolving partition path parsing failures when using numbers and hyphens. The update corrects craft-parts misinterpreting special character paths during lifecycle steps, addressing CRAFT-3031.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#493 partitions: validate usage of partitions in parts craft-parts merged Implemented partition validation for filepaths in the organize, overlay, stage, and prime keywords within parts. Merged after reviewer approval and passing CI checks, modifying seven files to resolve CRAFT-1844.
78%
#800 feat: allow hyphens in partition names craft-parts merged Merged to allow hyphens in partition names. Approved by two reviewers, the change updates five files with 85 additions and 51 deletions, resolving CRAFT-3031.
78%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged following two reviewer approvals and passing CI. Updates utility functions to handle namespaced partitions across eight files (+229/-72 lines). Resolves #596 and CRAFT-2303.
77%
#497 partitions: add utility to make partition compatible filepaths craft-parts merged Merged utility function to convert filepaths to partition-compatible formats. Approved by two reviewers, the change adds 184 lines across two files and addresses CRAFT-1845.
75%
#763 partitions feature documentation craft-parts merged Merged documentation for the partitions feature targeting application developers. Approved by two reviewers, the update adds 66 lines and removes 5 across nine files, resolving CRAFT-3030.
74%
#371 docs: add howto for using partitions craft-application merged Merged a how-to guide for using partitions. Approved by two reviewers, the update adds 197 lines across two files to document partition usage within the project. Resolves CRAFT-3068.
73%
#672 Using partitions introduces a breaking change craft-parts closed Fixed via a redesign in craft-parts issue #620. Partition support previously altered working directory paths, breaking relative path references in build overrides. The redesign resolves the path inconsistency, restoring expected behavior.
73%
#826 feat(partitions): custom error for nonexistent partition craft-parts merged Merged a feature introducing a custom error for nonexistent partitions to improve error handling in corncraft. Approved by three reviewers, passed CI, and modified three files. Temporary linter failures from cmake.org downtime were resolved prior to merge.
73%
#88 feat: create craft partitions from structure items imagecraft merged Merged implementation of dynamic craft partition creation from structure items in the Volumes section, resolving issue #81. Approved by two reviewers and passed CI checks across 12 files.
72%
#652 feat(partitions): clean partition directories craft-parts merged Merged changes cleaning partition directories when the partitions feature is enabled. Approved by two reviewers, passed CI, and resolves issue #634.
70%