← Back to issue list

feat: allow the plus sign in partition names

View original Github issue

Metadata

Project
craft-parts
Number
#1612
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1612 as commit 5d5b792a, expanding partition-name validation to permit plus signs used by .deb package names.

Resolution: closed resolved

Reason: The approved PR passed all CI checks and was merged into main as commit 5d5b792a, implementing the requested partition-name support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The plus sign is a valid character in .deb package names and Debcraft uses partitions to prime package contents. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- CRAFT-5183

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1612 as commit 5d5b792a, expanding partition-name validation to permit plus signs used by .deb package names.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-parts#1612, allowing “+” in partition names so Debcraft can use valid .deb package-name characters.
qwen/qwen3.6-35b-a3b — — Merged. Enables the plus sign in partition names to support valid .deb package naming in Debcraft. Approved by two reviewers, passed all CI checks, and resolves CRAFT-5183.
qwen3.6-35b-a3b-mtp-q6 — — Merged to allow the plus sign in partition names, supporting .deb package naming conventions and Debcraft partition priming. Resolves CRAFT-5183.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1594 fix(partitions): allow plus signs in partition names craft-parts closed Closed unmerged after its plus-sign partition-name support was consolidated into merged PR #1612, committed as 5d5b792a.
83%
#1593 Allow the + character in partition names craft-parts closed Partition-name validation now permits “+” for valid Debian package names; fixed by merged PR canonical/craft-parts#1612 (commit 5d5b792a).
81%
#790 feat: allow numbers in partition names and namespaces craft-parts merged Merged PR #790 (commit b2128938) relaxes partition/namespace name validation to allow numbers; unblocked LP#2069783 (CRAFT-3043). Follow-up for hyphens filed as #789, fixed later by #800.
72%
#1002 feat: Allow slashes in partition names craft-parts merged Merged as c2e41898, allowing slashes in partition names and fixing #999 (CRAFT-4064).
71%
#800 feat: allow hyphens in partition names craft-parts merged Merged PR #800 as commit 184d5142, adding support for hyphens in partition names for CRAFT-3031.
71%