feat: partitions always enabled
Metadata
Current evaluation
Maintainer refactor merging the enabled/disabled partition code paths so partitions are always active with a default-only fallback. +699/-603 across 43 files; rebased 11 days ago, unreviewed, no approvals, one CI job failing.
Suggested action: needs review
Reason: Author (maintainer) rebased on main ('Rebased on main.'2026-09-06) and it is sitting with 0 reviewers and no approvals; the body checklist is entirely unchecked, including the required changelog entry in docs/reference/changelog.rst. CI is not clean — 'test-common / Minimum dependencies (all tests)' is failing while 13 checks remain pending — so it needs a maintainer look before landing, but nothing indicates abandonment or a superseded implementation.
Evaluated by: mr-cal-bot
Impact:
45
Quick Win:
7
Complexity:
72
Confidence:
70
Actionability:
52
Issue body
Consolidate code paths for enabled and disabled partition feature,
making the no partitions case a special case where only the default
partition is used.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
45
Quick Win:
7
Complexity:
72
Confidence:
70
Actionability:
52
|
needs review | Maintainer refactor merging the enabled/disabled partition code paths so partitions are always active with a default-only fallback. +699/-603 across 43 files; rebased 11 days ago, unreviewed, no approvals, one CI job failing. | |
| stealth/space-bunny-alpha |
Impact:
56
Quick Win:
7
Complexity:
75
Confidence:
86
Actionability:
50
|
needs review | Partitions are now always enabled, unifying core execution with a default-only fallback. Awaiting review after a rebase; one minimum-dependencies test job fails and 13 checks are pending. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
25
Staleness:
5
Complexity:
55
Confidence:
70
|
needs review | Consolidates enabled/disabled partition code paths into a unified approach where no partitions defaults to a single partition. CI passing, awaiting review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
18
Staleness:
10
Complexity:
70
Confidence:
75
|
needs review | Refactors craft-parts to always enable partitions, consolidating code paths. 31 files changed, ~1000 lines. Author rebased on main; 1 failing lint check; 0 reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
15
Staleness:
15
Complexity:
75
Confidence:
75
|
needs review | Consolidates partition code paths to always enable partitions, treating no-partition case as default partition only. PR from maintainer, 7 days old, pending CI checks, 0 reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
19
Staleness:
10
Complexity:
65
Confidence:
70
|
needs review | Consolidates partition feature code paths to always enable partitions, making the no-partition case a special case. Recently rebased on main with 0 reviewers and some failing CI tests. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
50
Quick Win:
25
Staleness:
10
Complexity:
50
Confidence:
70
|
needs review | Consolidates partition feature code paths, making disabled partitions a special case with only the default partition. CI passing, awaiting review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
18
Staleness:
10
Complexity:
70
Confidence:
60
|
needs review | Refactors craft-parts to always enable partitions, consolidating code paths. Fresh PR with 0 reviews, some CI failures (lint/files, slow tests). | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
65
Quick Win:
16
Staleness:
5
Complexity:
75
Confidence:
65
|
needs review | Consolidates partition code paths to always enable partitions. Recent PR with failing CI tests and unresolved review comments, awaiting maintainer review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
15
Staleness:
10
Complexity:
75
Confidence:
70
|
needs review | Refactors craft-parts to always enable partitions, consolidating code paths by treating the no-partitions case as a special case with only the default partition. 6 days old, 0 comments, 2 unresolved review comments, some CI tests failing. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/snapcraft#6397
(confidence 70%)
Open snapcraft PR titled 'feat: partitions always enabled' described as a manual-spread follow-up to this craft-parts change; downstream adoption still in flight.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6397 feat: partitions always enabled | snapcraft | open | Turns on craft-parts partitions consistently in snapcraft (4 files, +8/-9) as a manual-spread follow-up to craft-parts#1699. Awaiting review: lint/files failing, 3 checks pending, one unresolved comment, upstream craft-parts PR still open. | |
| #4487 [DRAFT] feat: enable partitions | snapcraft | closed | Draft PR #4487 was closed unmerged and replaced by #4493, which conditionally enabled partitions and fixed #4463; implementation landed in commit 070c7e995. | |
| #652 feat(partitions): clean partition directories | craft-parts | merged | Merged #652 via commit 797109e8, adding partition-directory cleanup when partitions are enabled and fixing #634 (CRAFT-2417). | |
| #4493 feat(lifecycle): conditionally enable partitions | snapcraft | merged | Merged PR #4493 enabled partitions for devel/core24+ projects with components, added component lifecycle variables, and fixed #4463 and #4465; it replaced #4487. |