feat: partitions always enabled
Metadata
Current evaluation
Consolidates enabled/disabled partition code paths into a unified approach where no partitions defaults to a single partition. CI passing, awaiting review.
Suggested action: needs review
Reason: The PR is fresh (7 days old, last activity today), CI is fully passing, and it consolidates partition code paths across 31 files. It has no reviewers yet and is pending review. The related snapcraft#6397 PR suggests this feature is being coordinated across projects, warranting maintainer attention.
Impact:
55
Quick Win:
24.75
Staleness:
5
Complexity:
55
Confidence:
70
Issue body
Consolidate code paths for enabled and disabled partition feature,
making the no partitions case a special case where only the default
partition is used.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
24.75
Staleness:
5
Complexity:
55
Confidence:
70
|
needs review | Consolidates enabled/disabled partition code paths into a unified approach where no partitions defaults to a single partition. CI passing, awaiting review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
18.0
Staleness:
10
Complexity:
70
Confidence:
75
|
needs review | Refactors craft-parts to always enable partitions, consolidating code paths. 31 files changed, ~1000 lines. Author rebased on main; 1 failing lint check; 0 reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
15.0
Staleness:
15
Complexity:
75
Confidence:
75
|
needs review | Consolidates partition code paths to always enable partitions, treating no-partition case as default partition only. PR from maintainer, 7 days old, pending CI checks, 0 reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
19.25
Staleness:
10
Complexity:
65
Confidence:
70
|
needs review | Consolidates partition feature code paths to always enable partitions, making the no-partition case a special case. Recently rebased on main with 0 reviewers and some failing CI tests. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
50
Quick Win:
25.0
Staleness:
10
Complexity:
50
Confidence:
70
|
needs review | Consolidates partition feature code paths, making disabled partitions a special case with only the default partition. CI passing, awaiting review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
18.0
Staleness:
10
Complexity:
70
Confidence:
60
|
needs review | Refactors craft-parts to always enable partitions, consolidating code paths. Fresh PR with 0 reviews, some CI failures (lint/files, slow tests). | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
65
Quick Win:
16.25
Staleness:
5
Complexity:
75
Confidence:
65
|
needs review | Consolidates partition code paths to always enable partitions. Recent PR with failing CI tests and unresolved review comments, awaiting maintainer review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
15.0
Staleness:
10
Complexity:
75
Confidence:
70
|
needs review | Refactors craft-parts to always enable partitions, consolidating code paths by treating the no-partitions case as a special case with only the default partition. 6 days old, 0 comments, 2 unresolved review comments, some CI tests failing. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
snapcraft#6397
(confidence 85%)
Same feature title and scope in snapcraft, suggesting coordinated cross-project work on always-enabling partitions.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6397 feat: partitions always enabled | snapcraft | open | Small change to always enable partitions unconditionally. No reviews, no comments, 16 days old, CI passing. | |
| #652 feat(partitions): clean partition directories | craft-parts | merged | Merged changes cleaning partition directories when the partitions feature is enabled. Approved by two reviewers, passed CI, and resolves issue #634. | |
| #4493 feat(lifecycle): conditionally enable partitions | snapcraft | merged | Merged after approval and CI checks. Conditionally enables partitions for components on core24 or newer bases, generates partitions from definitions, and adds environment variables. Resolves #4463 and #4465. | |
| #1144 feat: Use the first partition in the list as the default | craft-parts | merged | Merged. Treats the first partition as default, supporting custom names and explicit default references. Migration states now track partition names. Approved by two reviewers, passed all CI checks, and modified 30 files. | |
| #4487 [DRAFT] feat: enable partitions | snapcraft | closed | Superseded by PR #4493. The proposal to enable partitions unconditionally was revised per reviewer feedback to only activate when components are declared. The PR was closed without merging. | |
| #4700 feat: partitions for core24 | snapcraft | merged | Merged feature adding partitions for core24. Approved by two reviewers, the PR modifies 16 files (+461/-26 lines). Codecov flagged 10 lines missing coverage, but the changes were successfully integrated into main. |