← Back to issue list

feat: partitions always enabled

View original Github issue

Metadata

Project
snapcraft
Number
#6397
Type
pull request
State
open
Author
cmatsuoka
Labels
PR: Run Manual Spread
Created
Updated
Closed
—

Current evaluation

Turns on craft-parts partitions consistently in snapcraft (4 files, +8/-9) as a manual-spread follow-up to craft-parts#1699. Awaiting review: lint/files failing, 3 checks pending, one unresolved comment, upstream craft-parts PR still open.

Suggested action: keep open

Reason: The PR is queued under the 'PR: Run Manual Spread' label and is authored by a maintainer, so it is in an active review cycle rather than abandoned — but it cannot land yet: 'lint / files' is failing, build/snap-build/fast-tests/minimum-deps are still pending, and one review comment is unresolved. It is also gated on craft-parts#1699 ('feat: partitions always enabled', still open), which must land and release before snapcraft can always enable partitions, so the correct next step is the author fixing lint and the upstream landing, not merging or closing.

Evaluated by: mr-cal-bot

Impact: 40 Quick Win: 11 Complexity: 30 Confidence: 68 Actionability: 38

Issue body

Describe your changes. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 40
Quick Win: 11
Complexity: 30
Confidence: 68
Actionability: 38
keep open Turns on craft-parts partitions consistently in snapcraft (4 files, +8/-9) as a manual-spread follow-up to craft-parts#1699. Awaiting review: lint/files failing, 3 checks pending, one unresolved comment, upstream craft-parts PR still open.
stealth/space-bunny-alpha
Impact: 35
Quick Win: 8
Complexity: 25
Confidence: 68
Actionability: 32
keep open Small 4-file change (+8/-9) to always enable partitions in Snapcraft, companion to the open craft-parts#1699. Maintainer-authored, 0 reviews; lint/files failing and build/test jobs still pending.
stealth/space-bunny-alpha
Impact: 48
Quick Win: 15
Complexity: 32
Confidence: 78
Actionability: 45
keep open Enables partitions consistently in four files as a manual-spread follow-up to craft-parts#1699. Lint fails, several checks remain pending, and one review thread is unresolved.
qwen3.6-35b-a3b-mtp-q6
Impact: 55
Quick Win: 41
Staleness: 45
Complexity: 25
Confidence: 55
needs review Small change to always enable partitions unconditionally. No reviews, no comments, 16 days old, CI passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Enables partitions by default across 4 files with a minimal 9/10 line diff. Currently awaiting maintainer review and pending CI completion.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Unconditionally enables partition configuration across 4 files. Currently awaiting maintainer review with one unresolved comment. CI shows mixed results with failing tests and lint checks, while integration jobs are pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Enables partitions by default across two files. Currently pending maintainer review with one unresolved comment. CI shows two failing tests and several pending jobs.

Update history

Date Change
updated
updated
updated
created

Related work

  • Blocked By: craft-parts#1699 (confidence 88%)

    Same title 'feat: partitions always enabled'; this snapcraft PR is the manual-spread follow-up that turns on partitions only after the craft-parts behavior lands and is released.

  • Related To: snapcraft#4463 (confidence 55%)

    Original 'Enable craft-parts partitions feature' work (closed via merged PR #4493); this PR changes the same partitioning enablement from opt-in to always-on.

Related issues

Issue Project State Summary Similarity
#1699 feat: partitions always enabled craft-parts open Maintainer refactor merging the enabled/disabled partition code paths so partitions are always active with a default-only fallback. +699/-603 across 43 files; rebased 11 days ago, unreviewed, no approvals, one CI job failing.
76%
#4463 Enable craft-parts partitions feature snapcraft closed Partitions support landed in merged PR #4493 (commit 070c7e995), enabling partition-backed component lifecycle data and completing #4463.
75%
#493 partitions: validate usage of partitions in parts craft-parts merged Merged into craft-parts in commit ed20df71 (#493), adding validation of partition usage in filepaths for parts' organize, overlay, stage and prime keywords (CRAFT-1844).
74%
#652 feat(partitions): clean partition directories craft-parts merged Merged #652 via commit 797109e8, adding partition-directory cleanup when partitions are enabled and fixing #634 (CRAFT-2417).
73%
#754 Document Partitions craft-parts closed Partitions documentation was added and the issue completed by merged PR canonical/craft-parts#763 in commit cdcc9dbc.
73%
#1110 feat: cleaning with partitions craft-parts merged Merged PR #1110 adds partition-aware cleanup of shared areas for CRAFT-4585, following prerequisite #1109; it is recorded on main as commit 0584c19c.
72%
#763 partitions feature documentation craft-parts merged Merged developer-facing partitions documentation in commit cdcc9dbc, completing CRAFT-3030 after approval by two reviewers.
72%
#489 partitions: add feature and validation craft-parts merged Merged as commit d363fa7c, adding the opt-in partitions feature to LifecycleManager/Dirs, partition name validation with new partition errors, and integration tests for CRAFT-1843. Follow-up PRs #493, #497 and #517 extended it.
71%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged into main in commit f387afa5 (PR #600), adding namespaced-partition handling to four partition utilities and resolving craft-parts#596.
70%