← Back to issue list

feat: partitions always enabled

View original Github issue

Metadata

Project
snapcraft
Number
#6397
Type
pull request
State
open
Author
cmatsuoka
Labels
PR: Run Manual Spread
Created
Updated
Closed
—

Current evaluation

Small change to always enable partitions unconditionally. No reviews, no comments, 16 days old, CI passing.

Suggested action: needs review

Reason: This PR (+9/-10 lines) is authored by maintainer cmatsuoka and has no reviews or comments after 16 days. The change appears to remove the conditional check for components in _enable_craft_parts_features() to always enable partitions, which is a behavioral shift from the current conditional logic. Without reviewer input or a linked issue explaining the rationale, maintainer review is needed before proceeding.

Impact: 55 Quick Win: 41.25 Staleness: 45 Complexity: 25 Confidence: 55

Issue body

Describe your changes. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 55
Quick Win: 41.25
Staleness: 45
Complexity: 25
Confidence: 55
needs review Small change to always enable partitions unconditionally. No reviews, no comments, 16 days old, CI passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Enables partitions by default across 4 files with a minimal 9/10 line diff. Currently awaiting maintainer review and pending CI completion.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Unconditionally enables partition configuration across 4 files. Currently awaiting maintainer review with one unresolved comment. CI shows mixed results with failing tests and lint checks, while integration jobs are pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Enables partitions by default across two files. Currently pending maintainer review with one unresolved comment. CI shows two failing tests and several pending jobs.

Update history

Date Change
updated
updated
created

Related work

  • Related To: canonical/snapcraft#4463 (confidence 70%)

    Original issue for enabling partitions feature, resolved by PR #4493 which conditionally enables partitions for components. This PR appears to be a follow-up to make partitions always enabled instead of conditional.

Related issues

Issue Project State Summary Similarity
#1699 feat: partitions always enabled craft-parts open Consolidates enabled/disabled partition code paths into a unified approach where no partitions defaults to a single partition. CI passing, awaiting review.
83%
#4700 feat: partitions for core24 snapcraft merged Merged feature adding partitions for core24. Approved by two reviewers, the PR modifies 16 files (+461/-26 lines). Codecov flagged 10 lines missing coverage, but the changes were successfully integrated into main.
71%
#652 feat(partitions): clean partition directories craft-parts merged Merged changes cleaning partition directories when the partitions feature is enabled. Approved by two reviewers, passed CI, and resolves issue #634.
71%