[DRAFT] feat: enable partitions
Metadata
Current evaluation
Draft PR #4487 was closed unmerged and replaced by #4493, which conditionally enabled partitions and fixed #4463; implementation landed in commit 070c7e995.
Resolution: closed superseded
Reason: The maintainer explicitly marked #4487 as replaced by #4493. PR #4493 merged the refined conditional partition implementation in commit 070c7e995.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Enable the partitions feature for `craft-parts` and use the `default` partition.
### Known issues
- [ ] patchelf unit test is [failing](https://github.com/snapcore/snapcraft/actions/runs/7145879806/job/19462461133?pr=4487#step:6:352) because something is changing the ownership of `prime/default/`
- [ ] patchelf spread tests are [failing](https://github.com/snapcore/snapcraft/actions/runs/7145879807/job/19462618378?pr=4487#step:4:450) and the logs are not informative
- [ ] conda hello-world spread test is [timing out](https://github.com/snapcore/snapcraft/actions/runs/7145879807/job/19462618378?pr=4487#step:4:17611) because the contents of `stage/default` is somehow getting nested within itself and it takes twice as long to package the snap
- [ ] this [bug fix](https://github.com/canonical/craft-parts/pull/607) in craft-parts
- [ ] `snapcraft try` [failing](https://github.com/snapcore/snapcraft/actions/runs/7145879807/job/19462618378?pr=4487#step:4:1408) spread tests
Fixes #4463
(CRAFT-2307)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Draft PR #4487 was closed unmerged and replaced by #4493, which conditionally enabled partitions and fixed #4463; implementation landed in commit 070c7e995. | |
| stealth/space-bunny-alpha | — | closed superseded | Draft PR enabling craft-parts partitions unconditionally was closed unmerged by author mr-cal (2023-12-12) as "Replaced by #4493"; the work landed in merged PR #4493 (commit 070c7e995) which enables partitions only when components are declared. | |
| stealth/space-bunny-alpha | — | closed superseded | Unmerged partition-enablement draft #4487 was closed as superseded by merged #4493, which conditionally enables partitions and defines a default partition. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #4493. The proposal to enable partitions unconditionally was revised per reviewer feedback to only activate when components are declared. The PR was closed without merging. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #4493. The original attempt to enable partitions for craft-parts encountered test failures and design feedback. The feature was reworked and continued in the replacement pull request. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#4493
(confidence 100%)
Superseding PR merged conditional partition enablement and partition environment-variable support.
-
Likely Fixed By:
snapcraft#4493
(confidence 100%)
Merged implementation resolved the underlying partition-enablement issue #4463.
-
Related To:
snapcraft#4463
(confidence 100%)
Original issue targeted by #4487 and fixed by #4493.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4493 feat(lifecycle): conditionally enable partitions | snapcraft | merged | Merged PR #4493 enabled partitions for devel/core24+ projects with components, added component lifecycle variables, and fixed #4463 and #4465; it replaced #4487. | |
| #4463 Enable craft-parts partitions feature | snapcraft | closed | Partitions support landed in merged PR #4493 (commit 070c7e995), enabling partition-backed component lifecycle data and completing #4463. | |
| #763 partitions feature documentation | craft-parts | merged | Merged developer-facing partitions documentation in commit cdcc9dbc, completing CRAFT-3030 after approval by two reviewers. | |
| #1699 feat: partitions always enabled | craft-parts | open | Maintainer refactor merging the enabled/disabled partition code paths so partitions are always active with a default-only fallback. +699/-603 across 43 files; rebased 11 days ago, unreviewed, no approvals, one CI job failing. | |
| #489 partitions: add feature and validation | craft-parts | merged | Merged as commit d363fa7c, adding the opt-in partitions feature to LifecycleManager/Dirs, partition name validation with new partition errors, and integration tests for CRAFT-1843. Follow-up PRs #493, #497 and #517 extended it. |