← Back to issue list

[DRAFT] feat: enable partitions

View original Github issue

Metadata

Project
snapcraft
Number
#4487
Type
pull request
State
closed
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Superseded by PR #4493. The proposal to enable partitions unconditionally was revised per reviewer feedback to only activate when components are declared. The PR was closed without merging.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Enable the partitions feature for `craft-parts` and use the `default` partition. ### Known issues - [ ] patchelf unit test is [failing](https://github.com/snapcore/snapcraft/actions/runs/7145879806/job/19462461133?pr=4487#step:6:352) because something is changing the ownership of `prime/default/` - [ ] patchelf spread tests are [failing](https://github.com/snapcore/snapcraft/actions/runs/7145879807/job/19462618378?pr=4487#step:4:450) and the logs are not informative - [ ] conda hello-world spread test is [timing out](https://github.com/snapcore/snapcraft/actions/runs/7145879807/job/19462618378?pr=4487#step:4:17611) because the contents of `stage/default` is somehow getting nested within itself and it takes twice as long to package the snap - [ ] this [bug fix](https://github.com/canonical/craft-parts/pull/607) in craft-parts - [ ] `snapcraft try` [failing](https://github.com/snapcore/snapcraft/actions/runs/7145879807/job/19462618378?pr=4487#step:4:1408) spread tests Fixes #4463 (CRAFT-2307)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded by PR #4493. The proposal to enable partitions unconditionally was revised per reviewer feedback to only activate when components are declared. The PR was closed without merging.
qwen3.6-35b-a3b-mtp-q6 Superseded by pull request #4493. The original attempt to enable partitions for craft-parts encountered test failures and design feedback. The feature was reworked and continued in the replacement pull request.
qwen3.6-35b-a3b-mtp-q6 Superseded by PR #4493. The draft to enable partitions in craft-parts was closed after test failures and feedback to conditionally enable partitions only when components are declared.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4493 feat(lifecycle): conditionally enable partitions snapcraft merged Merged after approval and CI checks. Conditionally enables partitions for components on core24 or newer bases, generates partitions from definitions, and adds environment variables. Resolves #4463 and #4465.
72%
#1699 feat: partitions always enabled craft-parts open Consolidates enabled/disabled partition code paths into a unified approach where no partitions defaults to a single partition. CI passing, awaiting review.
70%