ci: Add missing permissions to QA lint workflow
Metadata
Current evaluation
Closed unmerged after the equivalent QA workflow permission fix landed in commit 585b7237.
Resolution: closed superseded
Reason: Commit 585b7237 added the read permissions for repository contents and pull-request metadata, resolving the same CI issue independently. PR #1741 has no recorded merge, replacement reference, or closing explanation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The QA workflow was invoking the shared lint workflow without the permissions it expects on pull request runs. This updates the lint job to explicitly grant the read access needed for repository contents and PR metadata.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after the equivalent QA workflow permission fix landed in commit 585b7237. | |
| stealth/space-bunny-alpha | — | closed stale | QA lint permissions PR was closed without a recorded merge or replacement; review remained pending and no maintainer comment explains the outcome. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
11
Complexity:
5
Confidence:
85
Actionability:
80
|
needs review | Adds 3 lines of explicit permissions (actions, contents, pull-requests: read) to the QA workflow so the reusable lint job works correctly on pull request runs. CI mostly passing. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| created |
Related work
-
Superseded By:
craft-parts@585b7237
(confidence 95%)
Commit titled "ci: fix permissions for QA workflow" independently implemented the requested permissions.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #600 ci: Add missing permissions to QA lint workflow | starbase | closed | PR #600 was closed unmerged despite all CI checks passing; no merge commit or recorded replacement was found. | |
| #6438 ci: Add missing permissions to QA lint workflow | snapcraft | closed | PR closed unmerged by lengau as redundant: the QA workflow (.github/workflows/qa.yaml) already grants workflow-level contents/pull-requests read permissions on main, so job-level permissions in the lint job were unnecessary. | |
| #216 ci: Add missing permissions to QA lint workflow | craft-grammar | closed | PR #216 (lengau) added explicit contents/pull-requests read permissions to the QA lint job and was approved, but the lint / files check failed; the PR was closed unmerged after ~8 days with no resolution recorded. | |
| #193 ci: Add missing permissions to QA lint workflow | debcraft | closed | Closed unmerged: all16 CI checks passed (incl. zizmor, lint / files, CLA) but review stayed pending (0 reviewers, 0 comments) and no merge commit or superseding change was recorded. | |
| #1375 ci: Add missing permissions to QA lint workflow | rockcraft | closed | PR #1375 (rockcraft) adding job-level contents/pull-requests read permissions to the QA lint workflow was closed unmerged by @lengau as redundant — the workflow's existing workflow-level permissions were already sufficient. | |
| #256 ci: Add missing permissions to QA lint workflow | craft-archives | merged | Job-level lint permissions PR closed as redundant by maintainer lengau: workflow-level read permissions already configured on main; superseded by merged PR #257 setting workflow-level read permissions. | |
| #427 ci: Add missing permissions to QA lint workflow | craft-store | closed | PR #427 (lengau) added job-level contents/pull-requests read permissions to craft-store's QA lint job (+3/-0). All CI checks passed but review stayed pending; closed unmerged in favour of workflow-level fix PR #428. | |
| #1191 ci: Fix QA workflow permissions for reusable lint job | craft-application | closed | PR #1191 was approved but closed unmerged; commit 5353ad50 records its lint permission change, while lint/files and title-policy checks still failed. | |
| #1731 ci: fix permissions for QA workflow | craft-parts | closed | Closed unmerged after approval: #1731 proposed explicit read permissions for incoming Starflow QA jobs, but no resolving commit landed and remaining CI checks never completed. | |
| #446 ci: Allow QA reusable workflows to read pull request metadata | imagecraft | closed | The QA permissions fix was approved but closed unmerged after the Conventional Commits policy check failed; no resolving commit or replacement was recorded. |