ci: Add missing permissions to QA lint workflow
Metadata
Current evaluation
PR closed unmerged by lengau as redundant: the QA workflow (.github/workflows/qa.yaml) already grants workflow-level contents/pull-requests read permissions on main, so job-level permissions in the lint job were unnecessary.
Resolution: closed not a bug
Reason: lengau closed canonical/snapcraft#6438 without merging, noting the team decided on workflow-level read permissions and that main already configures them in .github/workflows/qa.yaml (contents: read, pull-requests: read), introduced in commit cd8d4873 "ci: set read permissions for qa workflow (#557)". The proposed +3-line job-level grant was therefore not needed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The QA workflow was invoking the shared lint workflow without the permissions it expects on pull request runs. This updates the lint job to explicitly grant the read access needed for repository contents and PR metadata.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed not a bug | PR closed unmerged by lengau as redundant: the QA workflow (.github/workflows/qa.yaml) already grants workflow-level contents/pull-requests read permissions on main, so job-level permissions in the lint job were unnecessary. | |
| stealth/space-bunny-alpha | — | closed not a bug | Closed unmerged as redundant: main already grants workflow-level read permissions, making the proposed job-level permissions in canonical/snapcraft#6438 unnecessary. | |
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
20
Complexity:
10
Confidence:
85
Actionability:
75
|
needs review | Adds missing read permissions to the QA lint workflow for PR runs. All CI checks passing, awaiting review. |
Update history
| Date | Change |
|---|---|
| updated | |
| closed | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/snapcraft#557
(confidence 85%)
Commit cd8d4873 added workflow-level read permissions to .github/workflows/qa.yaml, which already satisfies the lint workflow's needs.
-
Related To:
canonical/snapcraft#585
(confidence 45%)
Earlier zizmor-driven CI hardening commit touching GitHub workflow permissions; same security-policy effort that motivated the PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #216 ci: Add missing permissions to QA lint workflow | craft-grammar | closed | PR #216 (lengau) added explicit contents/pull-requests read permissions to the QA lint job and was approved, but the lint / files check failed; the PR was closed unmerged after ~8 days with no resolution recorded. | |
| #1375 ci: Add missing permissions to QA lint workflow | rockcraft | closed | PR #1375 (rockcraft) adding job-level contents/pull-requests read permissions to the QA lint workflow was closed unmerged by @lengau as redundant — the workflow's existing workflow-level permissions were already sufficient. | |
| #256 ci: Add missing permissions to QA lint workflow | craft-archives | merged | Job-level lint permissions PR closed as redundant by maintainer lengau: workflow-level read permissions already configured on main; superseded by merged PR #257 setting workflow-level read permissions. | |
| #1741 ci: Add missing permissions to QA lint workflow | craft-parts | closed | Closed unmerged after the equivalent QA workflow permission fix landed in commit 585b7237. | |
| #427 ci: Add missing permissions to QA lint workflow | craft-store | closed | PR #427 (lengau) added job-level contents/pull-requests read permissions to craft-store's QA lint job (+3/-0). All CI checks passed but review stayed pending; closed unmerged in favour of workflow-level fix PR #428. | |
| #600 ci: Add missing permissions to QA lint workflow | starbase | closed | PR #600 was closed unmerged despite all CI checks passing; no merge commit or recorded replacement was found. | |
| #1191 ci: Fix QA workflow permissions for reusable lint job | craft-application | closed | PR #1191 was approved but closed unmerged; commit 5353ad50 records its lint permission change, while lint/files and title-policy checks still failed. | |
| #257 ci: Set workflow-level read permissions for QA workflow | craft-archives | merged | PR #257 by lengau merged as commit 7179169: moved QA workflow permissions to workflow-level read scopes (actions, contents, pull-requests) and dropped job-local lint overrides, fixing Starflow reusable workflow compilation on PRs. | |
| #193 ci: Add missing permissions to QA lint workflow | debcraft | closed | Closed unmerged: all16 CI checks passed (incl. zizmor, lint / files, CLA) but review stayed pending (0 reviewers, 0 comments) and no merge commit or superseding change was recorded. | |
| #194 ci: Set workflow-level read permissions for QA workflow | debcraft | merged | PR #194 merged: added workflow-level read permissions (actions, contents, pull-requests) to .github/workflows/qa.yaml and removed lint job-level overrides, fixing Starflow reusable workflow compilation on PRs. |