← Back to issue list

feat: cut build-slices in the prologue

View original Github issue

Metadata

Project
craft-parts
Number
#1718
Type
pull request
State
open
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Adds build-slice cutting in the prologue phase after installing build packages. Approved by 1 reviewer with 2 unresolved comments; 4 CI checks failing on minimum dependencies.

Suggested action: needs review

Reason: The PR has 1 approval but 2 unresolved review comments that need to be addressed before merging. It is only 1 day old and under active review. The 4 failing CI checks (minimum dependencies tests) also require investigation.

Impact: 55 Quick Win: 30.25 Staleness: 5 Complexity: 45 Confidence: 75

Issue body

Cut requested 'build-slices' after installing build packages and snaps. The build-slices from all parts are collected and de-duplicated into a single "chisel cut" call. One caveat here is that since the executor is "stateless" there is no way to "preserve" cut slices between lifecycle runs, because we don't know which slices were cut previously and whether the list of requested slices was changed. So the safe approach is to always-recut, which is inefficient but gives the correct set of cut slices. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30.25
Staleness: 5
Complexity: 45
Confidence: 75
needs review Adds build-slice cutting in the prologue phase after installing build packages. Approved by 1 reviewer with 2 unresolved comments; 4 CI checks failing on minimum dependencies.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30.25
Staleness: 5
Complexity: 45
Confidence: 70
needs review Adds build-slice cutting in the lifecycle prologue phase, collecting and deduplicating slices across parts into a single chisel cut call. Currently has 2 unresolved review comments and 4 failing CI checks.
qwen/qwen3.6-35b-a3b
Impact: 70
Quick Win: 24.5
Staleness: 5
Complexity: 65
Confidence: 75
needs review Adds build-slices cutting to executor prologue after install steps. Fresh PR with 4 failing CI tests and 2 unresolved review comments.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30.25
Staleness: 5
Complexity: 45
Confidence: 70
needs review Adds build-slice cutting in the prologue lifecycle phase, collecting and deduplicating slices from all parts into a single chisel cut call. New PR with some failing minimum-dependency CI tests.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 25.0
Staleness: 0
Complexity: 50
Confidence: 60
needs review Feature to cut build-slices in the prologue after installing build packages and snaps. New PR with 0 reviews, 0 comments, and 2 failing minimum-dependency CI jobs.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 19.25
Staleness: 5
Complexity: 65
Confidence: 75
needs review Adds build-slices cutting in the lifecycle prologue, collecting and deduplicating slices across parts into a single chisel cut call. Fresh PR with passing CI, no reviews yet.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 32.5
Staleness: 0
Complexity: 35
Confidence: 75
needs review New feature adding build-slice cutting in the lifecycle prologue. Fresh PR with passing CI, no reviews yet, authored by maintainer tigarmo.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1717 feat(part): add build-slices model craft-parts closed Merged the addition of a build-slices Part property listing Chisel slices for the build root. The change introduces a new feature flag and validation logic. Approved by a reviewer and passed all CI checks.
73%