build: add lint-code make target from starbase
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Adds lint-code make target grouping code linters and updates lint to depend on it. Approved, CI mostly passing, ready for maintainer merge.
Resolution: needs review
Reason: PR is approved with 0 unresolved review comments and CI is passing (the failing checks appear to be pre-existing issues unrelated to this change, as noted by the author that lint-ty fails identically on main). The change is a small, well-scoped Makefile addition (+4/-1 lines) that ports the lint-code target from starbase.
Evaluated by: mr-cal-bot
Impact:
25
Quick Win:
18
Complexity:
10
Confidence:
85
Actionability:
80
Issue body
Ports the `lint-code` target from starbase's Makefile: `lint-code` groups the code-specific linters (ruff, ty, codespell, prettier, shfmt, shellcheck, tombi), and `lint` now depends on it alongside `lint-docs`, `lint-twine`, and `lint-uv-lockfile`, matching starbase.
Side effect: `make lint` now also runs `lint-shfmt` and `lint-tombi`, which were previously only reachable via `make format`. starbase's `lint-actions` dependency on `lint` is intentionally not ported, to keep the change to the requested target.
Verified: `make lint-code` — all members pass except `lint-ty`, which fails identically on `main` (pre-existing `lxml.etree` unresolved-import errors, 7 diagnostics).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
25
Quick Win:
18
Complexity:
10
Confidence:
85
Actionability:
80
|
needs review | Adds lint-code make target grouping code linters and updates lint to depend on it. Approved, CI mostly passing, ready for maintainer merge. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| created |
Related work
-
Related To:
starbase#549
(confidence 90%)
The PR ports the lint-code target from starbase's Makefile, which is referenced in the related issues as the source of this change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #549 build(Makefile): add lint-code target | starbase | merged | PR #549 by mr-cal was merged (commit 875e9e7), adding a `lint-code` Makefile target to starcraft's top-level Makefile that runs code linters (ruff, ty, codespell, mypy, prettier, pyright, shfmt, shellcheck, tombi). | |
| #594 build: run docs-clean as part of clean target | starbase | merged | Merged PR canonical/starbase#594 makes the top-level `clean` target depend on the docs `docs-clean` target, so stale docs/_dev/styles/ no longer cause CI-only `make lint-docs` failures. One-line Makefile change, approved and merged. | |
| #493 fix(build): false lint errors | starbase | merged | Merged in canonical/starbase#493 via commit b304e0a, fixing false lint errors by ignoring .sphinx and separating sphinx-lint arguments; all CI checks passed. |