← Back to issue list

build(Makefile): add lint-code target

View original Github issue

Metadata

Project
starbase
Number
#549
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #549 by mr-cal was merged (commit 875e9e7), adding a `lint-code` Makefile target to starcraft's top-level Makefile that runs code linters (ruff, ty, codespell, mypy, prettier, pyright, shfmt, shellcheck, tombi).

Resolution: closed resolved

Reason: The PR was approved by two reviewers with all CI checks passing and merged into main as commit 875e9e7 ("build(Makefile): add lint-code target (#549)"). The target is present in the current Makefile, where `lint` now depends on `lint-code lint-docs lint-twine lint-uv-lockfile lint-actions`.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Adds a new `make lint-code` target. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #549 by mr-cal was merged (commit 875e9e7), adding a `lint-code` Makefile target to starcraft's top-level Makefile that runs code linters (ruff, ty, codespell, mypy, prettier, pyright, shfmt, shellcheck, tombi).
stealth/space-bunny-alpha — closed resolved Merged in #549 (875e9e7), adding a Makefile lint-code target for code linting.
qwen/qwen3.6-35b-a3b — — Merged. Added a make lint-code target to the Makefile to streamline code linting. Approved by two reviewers, passed all CI checks, and implemented with a minimal four-line change.
qwen3.6-35b-a3b-mtp-q6 — — Merged a maintainer's pull request adding a make lint-code target to the Makefile. The change passed lint and test checks and was integrated without comments or documentation updates.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1234 build(Makefile): add lint-code target craft-application merged Merged PR #1234 adding a lint-code Makefile target for code-specific linters, refactoring the lint target to depend on it alongside non-code linters.
86%
#1787 build(Makefile): add lint-code target craft-parts closed PR #1787 adds a lint-code Makefile target grouping code-specific linters, but was closed unresolved with merge conflicts pending.
84%
#669 build(Makefile): add lint-code target fetch-service open Adds a lint-code Makefile target grouping code linters, following the starbase pattern. CI mostly passing, awaiting review.
84%
#1784 build: add lint-code make target from starbase craft-parts merged Merged PR #1784, adding the lint-code make target from starbase and updating make lint to include lint-shfmt and lint-tombi.
77%