build: run docs-clean as part of clean target
Metadata
Current evaluation
Merged a one-line Makefile update adding docs-clean to the clean target. This resolves CI lint failures from stale documentation styles by ensuring make clean removes generated artifacts. Approved by two reviewers and passed all CI checks.
Suggested action: —
No scores available.
Issue body
Other top-level targets, like `make lint`, target the docs. `make clean` should follow the same pattern.
I was having an issue where `make lint-docs` was only failing in CI. The problem was that `docs/_dev/styles/` was out-of-date and `make clean` wasn't cleaning it.
Source: https://github.com/canonical/snapcraft/pull/6391#discussion_r3807835072
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line Makefile update adding docs-clean to the clean target. This resolves CI lint failures from stale documentation styles by ensuring make clean removes generated artifacts. Approved by two reviewers and passed all CI checks. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the Makefile adding docs-clean to the clean target. Resolves CI lint failures caused by stale documentation styles by ensuring proper build cleanup. Approved by reviewers and passed all checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
95
|
needs review | Updates Makefile to include docs-clean in the clean target, resolving CI lint-docs failures caused by stale generated styles. Currently approved by one reviewer with all CI checks passing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
0
Complexity:
0
Confidence:
90
|
needs review | Updates Makefile to include docs-clean in the clean target, fixing CI lint-docs failures from stale generated files. Currently approved by one reviewer with pending CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
90
|
needs review | Updates Makefile to include docs-clean in the clean target, resolving CI lint-docs failures caused by stale generated styles. Approved by one reviewer, all CI checks passing, with one unresolved comment. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
95
|
needs review | Adds docs-clean to the Makefile clean target to resolve CI lint-docs failures from stale generated files. Approved by one reviewer, CI passing, ready for merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
0
Complexity:
5
Confidence:
95
|
needs review | Adds docs-clean to the Makefile clean target to fix CI lint failures caused by stale documentation artifacts. Currently approved with passing CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
95
|
needs review | Updates Makefile to include docs-clean in the clean target, resolving CI failures caused by outdated dev styles. Currently passing CI and awaiting maintainer review. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #566 build(docs): override docs-clean target | starbase | merged | Merged. Overrides the docs-clean Makefile target to prevent accidental virtual environment deletion and resolve ambiguous test command failures during documentation cleanup. Approved by reviewers and passed all CI checks. | |
| #525 build: fix docs-install target | starbase | merged | Merged a build fix optimizing the docs-install target by retaining dev dependencies throughout make lint execution. Approved by reviewers and passed CI checks, yielding a faster and more correct linting process. | |
| #477 build(docs): make `clean` target scrub `docs/reference/gen` | starbase | merged | Merged upstreamed changes to update the build clean target, ensuring it removes the generated docs/reference/gen directory. Approved by two reviewers and passed all CI checks. | |
| #6133 build: fix docs-install target | snapcraft | merged | Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI. | |
| #563 fix(build): collapse docs-install logs under parent targets | starbase | merged | Merged a Makefile update that collapses docs-install log output under parent targets to prevent CI log clutter. Approved by reviewers, passed all CI checks, and resolves the logging issue. | |
| #1423 build(docs): make `clean` target scrub `reference/gen` | craft-parts | merged | Merged. Updated the build clean target to explicitly scrub docs/reference/gen instead of relying on implicit Git ignores. Approved by three reviewers and passed CI checks, including all test suites and linting. | |
| #549 build(Makefile): add lint-code target | starbase | merged | Merged. Added a make lint-code target to the Makefile to streamline code linting. Approved by two reviewers, passed all CI checks, and implemented with a minimal four-line change. |