build: run docs-clean as part of clean target
Metadata
Current evaluation
Merged PR canonical/starbase#594 makes the top-level `clean` target depend on the docs `docs-clean` target, so stale docs/_dev/styles/ no longer cause CI-only `make lint-docs` failures. One-line Makefile change, approved and merged.
Resolution: closed resolved
Reason: PR #594 was merged into starbase's main branch with a single-line Makefile change (+1/-1) adding docs-clean to the clean target; this fixed the CI-only lint-docs failure caused by an out-of-date docs/_dev/styles/ directory. Referenced in the discussion at canonical/snapcraft#6391.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Other top-level targets, like `make lint`, target the docs. `make clean` should follow the same pattern.
I was having an issue where `make lint-docs` was only failing in CI. The problem was that `docs/_dev/styles/` was out-of-date and `make clean` wasn't cleaning it.
Source: https://github.com/canonical/snapcraft/pull/6391#discussion_r3807835072
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/starbase#594 makes the top-level `clean` target depend on the docs `docs-clean` target, so stale docs/_dev/styles/ no longer cause CI-only `make lint-docs` failures. One-line Makefile change, approved and merged. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/starbase#594, adding docs-clean to the clean target to remove stale documentation artifacts that caused CI-only lint-docs failures. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line Makefile update adding docs-clean to the clean target. This resolves CI lint failures from stale documentation styles by ensuring make clean removes generated artifacts. Approved by two reviewers and passed all CI checks. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the Makefile adding docs-clean to the clean target. Resolves CI lint failures caused by stale documentation styles by ensuring proper build cleanup. Approved by reviewers and passed all checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
95
|
needs review | Updates Makefile to include docs-clean in the clean target, resolving CI lint-docs failures caused by stale generated styles. Currently approved by one reviewer with all CI checks passing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
0
Complexity:
0
Confidence:
90
|
needs review | Updates Makefile to include docs-clean in the clean target, fixing CI lint-docs failures from stale generated files. Currently approved by one reviewer with pending CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
90
|
needs review | Updates Makefile to include docs-clean in the clean target, resolving CI lint-docs failures caused by stale generated styles. Approved by one reviewer, all CI checks passing, with one unresolved comment. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
95
|
needs review | Adds docs-clean to the Makefile clean target to resolve CI lint-docs failures from stale generated files. Approved by one reviewer, CI passing, ready for merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
0
Complexity:
5
Confidence:
95
|
needs review | Adds docs-clean to the Makefile clean target to fix CI lint failures caused by stale documentation artifacts. Currently approved with passing CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
95
|
needs review | Updates Makefile to include docs-clean in the clean target, resolving CI failures caused by outdated dev styles. Currently passing CI and awaiting maintainer review. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/snapcraft#6391
(confidence 70%)
Original review comment (discussion_r3807835072) that prompted this Makefile change; the docs styles issue surfaced there.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #566 build(docs): override docs-clean target | starbase | merged | Merged in canonical/starbase#566 as commit e56cce3, replacing docs-clean with a safe cleanup that removes generated documentation assets without deleting the virtual environment. | |
| #477 build(docs): make `clean` target scrub `docs/reference/gen` | starbase | merged | Merged PR #477 as commit 334adfe, updating the clean target to remove docs/reference/gen; upstreamed from canonical/craft-parts#1423. | |
| #1784 build: add lint-code make target from starbase | craft-parts | merged | Adds lint-code make target grouping code linters and updates lint to depend on it. Approved, CI mostly passing, ready for maintainer merge. | |
| #525 build: fix docs-install target | starbase | merged | Merged PR #525 as commit b434201, fixing docs-install so make lint keeps the correct development dependencies installed throughout linting. |