spread tests: remove legacy plugin tests
Metadata
Current evaluation
PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%).
Resolution: closed resolved
Reason: The PR was merged into master as commit 950fa2508 "spread tests: remove legacy plugin tests (#3432)". Reviewer approval was granted and codecov reported no coverage change; remaining test failures were noted as unrelated, tracked in #3431.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3432, removing 665 lines of legacy plugin spread tests across 29 files without changing coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes removing legacy plugin tests from the spread test suite. Author noted unrelated test failures were handled separately. Code coverage remained unchanged upon merge. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3431
(confidence 55%)
Author noted test failures were unrelated and being fixed in PR #3431.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5791 test: delete unused tests | snapcraft | merged | Merged as commit 3d1554584, removing 55 lines of obsolete, long-unused v1-plugin spread tests while retaining core20 coverage for external plugins. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. | |
| #486 test(spread): clean up plugin prep/restore | imagecraft | merged | Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability. | |
| #3269 spread tests: remove references of core16 | snapcraft | merged | Merged PR #3269 via commit ab84886f2, removing core16 references from three spread-test files. | |
| #4248 spread: separate legacy tests | snapcraft | closed | PR #4248 was merged into main, separating legacy spread tests into dedicated GitHub Actions runs to reduce repeated test execution after failures. | |
| #2763 fix(tests/spread): fix reactive spread tests | charmcraft | merged | Merged #2763 as 6e775f4a: split reactive spread coverage by legacy/Resolute, enabled binary wheels, and removed obsolete build flags. | |
| #3540 spread tests: remove 16.04 and core (CRAFT-210) | snapcraft | merged | Merged PR #3540 as ba522b2c9 (change 62e5eb7e4), removing Ubuntu 16.04 and core-only spread-test variants; non-duplicate coverage may return in later iterations. | |
| #3242 tests: migrate legacy classic patchelf tests to spread | snapcraft | merged | Merged PR #3242 as e76a07747, migrating legacy classic patchelf tests to Spread and removing 186 net lines across 13 files. | |
| #2199 tests: add spread suite for copy plugin | snapcraft | merged | Merged PR #2199 (f62504d) moved copy-plugin integration tests into a Spread suite, resolving LP #1783831. | |
| #4247 spread: separate legacy tests | snapcraft | closed | Closed PR #4247 was superseded by merged PR #4248, which split legacy spread tests into separate GitHub Actions runs to reduce repeated work after failures. |