← Back to issue list

spread tests: remove legacy plugin tests

View original Github issue

Metadata

Project
snapcraft
Number
#3432
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR.

Suggested action:

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR.
qwen3.6-35b-a3b-mtp-q6 Merged changes removing legacy plugin tests from the spread test suite. Author noted unrelated test failures were handled separately. Code coverage remained unchanged upon merge.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Removes legacy plugin tests from the spread test suite. Unrelated test failures were deferred to PR #3431. Code coverage remained unchanged upon integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2276 spread: move legacy wiki tests to spread snapcraft merged Merged following reviewer approval and passing CI. Relocated legacy wiki tests from integration tests to spread, updating 12 files with a net reduction of 42 lines. Addresses LP: #1792717.
81%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
81%
#5791 test: delete unused tests snapcraft merged Merged removal of unused spread tests for deprecated v1 plugins. Approved by two reviewers and passed most CI checks despite one failing integration test. Cleanup of a related file deferred pending core20 support removal.
80%
#3540 spread tests: remove 16.04 and core (CRAFT-210) snapcraft merged Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations.
80%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
80%
#1290 test(spread): clean up store tests charmcraft merged Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.
80%
#3020 spread tests: default base for local plugin tests snapcraft merged Merged updates to spread tests establishing a default base for local plugin tests. The change follows a prior commit pattern, adding two lines across two files. Approved by one reviewer and passed CI checks.
78%
#2199 tests: add spread suite for copy plugin snapcraft merged Merged into master following approval and passing CI. Moves copy plugin integration tests to a spread suite, resolving bug LP: #1783831. Modified 10 files, reduced code by 41 lines, and increased coverage by 0.02%.
78%
#3662 tests: update spread url snapcraft merged Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage.
77%
#2183 tests: add spread suite for cmake plugin snapcraft merged Merged into master, resolving LP #1783830 by migrating CMake plugin integration tests to a Spread suite. Approved, passed CI, and maintained 91.23% code coverage across 17 modified files.
77%