nodejs plugin: install during pull to support npm run
Metadata
Current evaluation
Merged in snapcraft#936 (commit 0497daaac), installing Node.js dependencies during pull so npm run commands can access them.
Resolution: closed resolved
Reason: Pull request #936 was merged, resolving the missing-dependency failure by adding installation during the pull phase.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Our install logic doesn't install dependencies during `pull` which makes
npm run commands that depend on these dependencies to fail.
LP: #1633298
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#936 (commit 0497daaac), installing Node.js dependencies during pull so npm run commands can access them. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#936 (commit 0497daaac), installing Node.js dependencies during pull so npm run commands can use them. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a nodejs plugin update that installs dependencies during pull operations. This resolves npm run command failures by ensuring required packages are available. Approved by one reviewer and modified five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the nodejs plugin to install dependencies during pull, resolving failures in npm run commands that rely on those dependencies. Addresses LP #1633298. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1633298 nodejs plugin never runs install during pull | snapcraft (launchpad) | closed | Bug where the nodejs plugin skipped npm install during pull (builddir check always false) was fixed by merged PR snapcore/snapcraft#936 (commit 0497daaac), which installs dependencies during pull. | |
| #1627871 Support run commands in the nodejs plugin | snapcraft (launchpad) | closed | Merged snapcraft#810 in commit a83d75e13, adding Node.js plugin support for npm run build, assembly, and packaging commands. Follow-up snapcraft#936 enabled dependency installation during pull. | |
| #810 nodejs plugin: Add mechanism to run “npm run” commands. | snapcraft | merged | Merged PR #810 in commit a83d75e13, adding Node.js plugin support for npm-run build commands; follow-up #936 enabled dependency installation during pull. | |
| #1245 nodejs plugin: add support for yarn. | snapcraft | merged | Merged Yarn support for Snapcraft's Node.js plugin in PR #1245 (commit 824a8ba79); the Yarn build test passed despite a Travis timeout. | |
| #200 plugins: npm | craft-parts | merged | Merged PR #200 as b9881154 (feature commit 343d5c6b), porting Snapcraft’s npm plugin and adding npm-include-node with a false default. | |
| #1518403 nodejs plugin | snapcraft (launchpad) | closed | Node.js plugin added via merged PR ubuntu-core/snapcraft#102 (commits 0336e05fb 'Initial implementation', merge b5ed4d7c0). Maintainer elopio closed the bug, noting the PR includes an example that snapped successfully on CI. |