nodejs plugin: install during pull to support npm run
Metadata
Current evaluation
Merged a nodejs plugin update that installs dependencies during pull operations. This resolves npm run command failures by ensuring required packages are available. Approved by one reviewer and modified five files.
Suggested action: —
No scores available.
Issue body
Our install logic doesn't install dependencies during `pull` which makes
npm run commands that depend on these dependencies to fail.
LP: #1633298
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a nodejs plugin update that installs dependencies during pull operations. This resolves npm run command failures by ensuring required packages are available. Approved by one reviewer and modified five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the nodejs plugin to install dependencies during pull, resolving failures in npm run commands that rely on those dependencies. Addresses LP #1633298. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix updates the nodejs plugin to install dependencies during pull, enabling npm run commands to execute successfully. Resolves LP: #1633298. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1633298 nodejs plugin never runs install during pull | snapcraft (launchpad) | closed | Fixed the nodejs plugin to run npm install during the pull phase by correcting the builddir path check, resolving downstream build failures. | |
| #810 nodejs plugin: Add mechanism to run “npm run” commands. | snapcraft | merged | Merged support for npm run commands in the nodejs plugin. Enables snap builds for projects relying on custom npm scripts instead of standard npm install. Approved by reviewers and integrated into the codebase. | |
| #1023 nodejs plugin: fix the plugin’s dependency installation | snapcraft | merged | Merged into master, this one-line change fixes the nodejs plugin dependency installation, resolving LP #1652542. The commit integrates cleanly with no impact on overall code coverage. | |
| #800 LP: #1623509 nodejs: fix to install dev-deps in build phase | snapcraft | merged | Merged a fix for the nodejs plugin to install devDependencies during the build phase. Approved by a reviewer after confirming unrelated CI failures, the change was successfully integrated. | |
| #2747 nodejs plugin: fix errors when building in confinement | snapcraft | merged | Merged fix for nodejs plugin confinement build errors. Unsets SUDO_UID, applies --unsafe-perm to npm install, moves installation out of the pull step, and skips npm ls for yarn. Approved and merged. | |
| #1245 nodejs plugin: add support for yarn. | snapcraft | merged | Added yarn support to the nodejs plugin. Approved by one reviewer, local tests passed, and the change was merged despite a Travis CI timeout. | |
| #719 feat(plugin): Refactor NPM plugin | craft-parts | merged | Merged NPM plugin refactoring. Adds NVM-style version support, moves Node.js downloads to pull phase, verifies SHA256 checksums, updates npm-install for v10+, sets NODE_ENV=production, and adds docs. Resolved #717. |