← Back to issue list

sources: add zip file source handler

View original Github issue

Metadata

Project
craft-parts
Number
#212
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #212 (merge commit 043b3da8, implementation a9b32b31) adding a ZipSource handler in craft_parts/sources/zip_source.py so parts can use 'source-type: zip', with unit tests and docs.

Resolution: closed resolved

Reason: The PR was approved and merged into main as 043b3da8 ('Merge pull request #212 from cmatsuoka/add-zip-source'), with implementation commit a9b32b31 creating ZipSource/ZipSourceModel, registering 'zip' in craft_parts/sources/__init__.py, and adding tests/unit/sources/test_zip_source.py.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Allow parts to specify zip files as sources. Co-authored-by: Kyle Fazzari <kyle@canonical.com> Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> Co-authored-by: Marius Gripsgard <marius@ubports.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #212 (merge commit 043b3da8, implementation a9b32b31) adding a ZipSource handler in craft_parts/sources/zip_source.py so parts can use 'source-type: zip', with unit tests and docs.
stealth/space-bunny-alpha — closed resolved Added ZIP archive source support, allowing parts to specify ZIP files as sources; PR canonical/craft-parts#212 was merged via 043b3da8 (implementation a9b32b31).
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-parts#212 in commit 043b3da8, adding a ZIP source handler so parts can use ZIP archives as sources; implementation commit a9b32b31.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI checks. Adds a zip file source handler allowing parts to specify zip archives as sources. Changes span six files with 261 additions and 7 deletions. Co-authored by Kyle Fazzari, Sergio Schvezov, and Marius Gripsgard.
qwen3.6-35b-a3b-mtp-q6 — — Merged, adding a zip file source handler to allow parts to specify zip archives as sources. Co-authored by Kyle Fazzari, Sergio Schvezov, and Marius Gripsgard. Successfully integrated into the main branch with no additional comments or revisions.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#740 (confidence 82%)

    Later merged PR adding the sibling SevenzipSource handler (94e401ed) modelled on the ZipSource handler introduced here.

Related issues

Issue Project State Summary Similarity
#232 sources: add 7z source handler craft-parts closed PR #232 (7z source handler) was never merged and was closed as superseded by canonical/craft-parts#740, which landed the feature in commit 94e401ed (craft_parts/sources/sevenzip_source.py).
75%
#523 Support zip files as source snapcraft merged Merged PR #523 (commit c9fe15076) adding zip file support as a part source handler, resolving LP bug #1577062. Retroactively approved by kyrofa.
73%
#970 sources: refactor zip source into module. snapcraft merged Merged PR #970 as commit db2a6fb6a, extracting the Zip source handler into sources/_zip.py as progress on LP bug #1648906.
72%