fix: rename plugin to plugin_name
Metadata
Current evaluation
Merged canonical/craft-parts#249 via d5ed9639 (merge d53bed65), renaming the string-valued plugin variable to plugin_name across five files before #250.
Resolution: closed resolved
Reason: The approved rename landed in commit d5ed9639 and was integrated by merge commit d53bed65 from PR #249. It changed the string-valued plugin variable to plugin_name ahead of follow-up PR #250.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Change `plugin` to `plugin_name`, because it is a string, not a `Plugin` object.
I would like to land this prior to https://github.com/canonical/craft-parts/pull/250#pullrequestreview-1042330556.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-parts#249 via d5ed9639 (merge d53bed65), renaming the string-valued plugin variable to plugin_name across five files before #250. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as d5ed9639 (merge d53bed65): renamed the PartInfo `plugin` attribute to `plugin_name` (it holds a string, not a Plugin object) across infos.py, executor and errors. Landed ahead of #250. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #249 (commit d5ed9639, merge d53bed65) renamed the string variable `plugin` to `plugin_name` across 5 files, clarifying it is a plugin name string rather than a Plugin object. Landed ahead of #250. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-parts#249 via d5ed9639 (merge d53bed65), renaming the string-valued plugin variable to plugin_name across five files before #250. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix renaming the plugin variable to plugin_name to accurately represent it as a string rather than a Plugin object. The change was approved, passed CI checks, and modified five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged a fix by mr-cal that renames the plugin variable to plugin_name to accurately reflect its string type instead of a Plugin object. The change was integrated into the codebase. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#250
(confidence 100%)
The PR body identifies #250 as a follow-up intended to land after this rename.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1645 docs: fix cmake plugin ref in parts explanation | craft-parts | merged | Merged in canonical/craft-parts#1645 (commit 0cc0e980), correcting the CMake plugin reference in the parts explanation after reviewer feedback. | |
| #1897 refactor: move parts plugins to their own module | charmcraft | merged | Merged PR #1897 (commit 392f859b), separating craft-parts plugins into charmcraft/parts/plugins and isolating them from other parts functionality. | |
| #5249 fix: update plugin build error message | snapcraft | closed | Closed unmerged as obsolete after craft-parts#1012 shipped; later testing moved to snapcraft#5273 and craft-parts#1025. |