← Back to issue list

fix: rename plugin to plugin_name

View original Github issue

Metadata

Project
craft-parts
Number
#249
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged a fix renaming the plugin variable to plugin_name to accurately represent it as a string rather than a Plugin object. The change was approved, passed CI checks, and modified five files.

Suggested action: —

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Change `plugin` to `plugin_name`, because it is a string, not a `Plugin` object. I would like to land this prior to https://github.com/canonical/craft-parts/pull/250#pullrequestreview-1042330556.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a fix renaming the plugin variable to plugin_name to accurately represent it as a string rather than a Plugin object. The change was approved, passed CI checks, and modified five files.
qwen3.6-35b-a3b-mtp-q6 — — Successfully merged a fix by mr-cal that renames the plugin variable to plugin_name to accurately reflect its string type instead of a Plugin object. The change was integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#263 plugins: fix cmake plugin prefix craft-parts merged Merged after two approvals and passing CI. Fixed cmake plugin prefix path formatting and aligned the installation prefix with v1 plugins. Rebased on main.
72%
#1573 docs: rename plugins '* use' -> '*-use' craft-parts merged Merged documentation update renaming plugin identifiers from * use to *-use for consistency. Approved by two reviewers and passed linting. Changes applied across nine files despite some failing slow CI checks.
71%
#2798 docs: fix typo in plugin migration guide charmcraft merged Merged a single-line fix correcting a typo in the plugin migration guide. Approved by two reviewers and passed all CI checks.
70%
#117 plugins: fix plugin properties test (CRAFT-483) craft-parts merged Merged fix for CRAFT-483 correcting instance assignment to the plugin properties class variable in tests. Approved by two reviewers and passed CI checks.
70%