← Back to issue list

test: xfail a git submodule test

View original Github issue

Metadata

Project
craft-parts
Number
#307
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 125677c5 to strict-xfail a Git submodule test disrupted by Ubuntu’s local-file transport policy; #309 later re-enabled it.

Resolution: closed resolved

Reason: PR #307 was merged as commit 125677c5, adding a strict xfail for the affected test. Its temporary workaround was superseded by merged PR #309 (a7dfeafb), which re-enabled the test with protocol.file.allow=always.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Latest versions of `git` in Ubuntu are patched to disallow adding submodules from local repos (using the 'file' transport). Refs: - https://bugs.launchpad.net/ubuntu/+source/git/+bug/1993586 - http://changelogs.ubuntu.com/changelogs/pool/main/g/git/git_2.34.1-1ubuntu1.5/changelog - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 125677c5 to strict-xfail a Git submodule test disrupted by Ubuntu’s local-file transport policy; #309 later re-enabled it.
stealth/space-bunny-alpha — closed resolved Merged a 4-line expected-failure marker for a Git submodule test because Ubuntu Git blocks local file-transport submodules. strict=True will re-enable failure detection when that behavior changes.
qwen/qwen3.6-35b-a3b — — Merged to mark a git submodule test as expected failure, addressing an Ubuntu patch that blocks local repo submodules. The test will automatically break again once upstream git restores the feature.
qwen3.6-35b-a3b-mtp-q6 — — Merged marking a git submodule test as expected to fail due to Ubuntu's patched git blocking local repo submodules. The strict xfail marker will automatically fail again once git reverts, ensuring timely cleanup.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#309 (confidence 100%)

    Merged commit a7dfeafb re-enabled the test and replaced #307's xfail workaround.

Related issues

Issue Project State Summary Similarity
#327 tests: backport git submodule test fix craft-parts merged Merged #327 backported #309/a7dfeafb, fixing the Git source test by allowing local file-protocol submodules in repositories created by the test suite.
72%
#309 tests: re-enable git submodule test craft-parts merged Merged in craft-parts#309 (commit a7dfeafb), re-enabling the Git submodule test with -c protocol.file.allow=always for test-created repositories.
72%