tests: re-enable git submodule test
Metadata
Current evaluation
Merged in craft-parts#309 (commit a7dfeafb), re-enabling the Git submodule test with -c protocol.file.allow=always for test-created repositories.
Resolution: closed resolved
Reason: PR #309 was merged as commit a7dfeafb, restoring the Git submodule test while explicitly permitting local file transport for repositories created by the test.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Adding "-c protocol.file.allow=always" on the test is fine because we're manipulating repos created by the test itself (so no security issue).
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-parts#309 (commit a7dfeafb), re-enabling the Git submodule test with -c protocol.file.allow=always for test-created repositories. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-parts#309 (a7dfeafb), re-enabling the Git submodule test with protocol.file.allow=always. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a pull request re-enabling the git submodule test by adding the -c protocol.file.allow=always flag. Approved by a reviewer, passed CI, and modified one file with a net addition of seven lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged re-enables the git submodule test by adding -c protocol.file.allow=always to safely handle test-created repositories without security risks. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-parts#307
(confidence 98%)
PR #307 previously marked the submodule test as expected to fail because local file transport was blocked; #309 re-enabled it.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #327 tests: backport git submodule test fix | craft-parts | merged | Merged #327 backported #309/a7dfeafb, fixing the Git source test by allowing local file-protocol submodules in repositories created by the test suite. | |
| #3953 tests: allow local git submodules | snapcraft | merged | Merged PR #3953 as commit 95de62207, adding protocol.file.allow=always to test Git commands so Git 2.34.1 permits local submodules. | |
| #3979 tests: allow local git submodules | snapcraft | merged | Merged PR #3979 as commit 5680eb7c5, allowing local submodules in tests by setting Git's protocol.file.allow=always for Git 2.34.1. | |
| #307 test: xfail a git submodule test | craft-parts | merged | Merged as 125677c5 to strict-xfail a Git submodule test disrupted by Ubuntu’s local-file transport policy; #309 later re-enabled it. |