tests: backport git submodule test fix
Metadata
Current evaluation
Merged #327 backported #309/a7dfeafb, fixing the Git source test by allowing local file-protocol submodules in repositories created by the test suite.
Resolution: closed resolved
Reason: PR #327 was approved and merged, carrying the fix from PR #309 in commit a7dfeafb. It safely enables protocol.file.allow=always for tests manipulating only their own repositories.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fix submodule handling in the git source unit test. Adding "-c protocol.file.allow=always" on the test is fine because we're manipulating repos created by the test itself (so no security issue).
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #327 backported #309/a7dfeafb, fixing the Git source test by allowing local file-protocol submodules in repositories created by the test suite. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged backport of #309 (a7dfeafb), allowing local file-protocol submodules in unit tests created by the suite. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a backported fix for git submodule handling in unit tests. The change adds a protocol flag to resolve test failures, received approval, passed CI checks, and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a backport that fixes git submodule handling in the git source unit test. The update adds -c protocol.file.allow=always to safely manipulate locally generated test repositories. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#309
(confidence 99%)
Original merged submodule-test fix that PR #327 backported.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3979 tests: allow local git submodules | snapcraft | merged | Merged PR #3979 as commit 5680eb7c5, allowing local submodules in tests by setting Git's protocol.file.allow=always for Git 2.34.1. | |
| #309 tests: re-enable git submodule test | craft-parts | merged | Merged in craft-parts#309 (commit a7dfeafb), re-enabling the Git submodule test with -c protocol.file.allow=always for test-created repositories. | |
| #3953 tests: allow local git submodules | snapcraft | merged | Merged PR #3953 as commit 95de62207, adding protocol.file.allow=always to test Git commands so Git 2.34.1 permits local submodules. | |
| #307 test: xfail a git submodule test | craft-parts | merged | Merged as 125677c5 to strict-xfail a Git submodule test disrupted by Ubuntu’s local-file transport policy; #309 later re-enabled it. |