← Back to issue list

sources: allow plus symbol in git url scheme

View original Github issue

Metadata

Project
craft-parts
Number
#321
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #321 in commit c993a1f9, allowing '+' in Git URL schemes so git+ssh:// source URLs are accepted; shipped in 1.19.1.

Resolution: closed resolved

Reason: PR #321 was approved and merged as commit c993a1f9. The 1.19.1 changelog confirms support for git+ssh in Git source entries.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add the plus symbol to valid git protocol scheme to allow entries using `git+ssh://`. This is allowed in Snapcraft 6 and displayed in Launchpad for git repos. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? (CRAFT-1489)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #321 in commit c993a1f9, allowing '+' in Git URL schemes so git+ssh:// source URLs are accepted; shipped in 1.19.1.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#321 as c993a1f9, allowing '+' in git URL schemes so git+ssh:// source URLs are accepted.
qwen/qwen3.6-35b-a3b — — Merged. Updated git URL scheme validation to accept the plus symbol, enabling git+ssh:// entries. Aligns with Snapcraft 6 and Launchpad requirements. Approved by one reviewer, passed CI, and modified two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged to add the plus symbol to valid git URL schemes, supporting git+ssh:// entries. Aligns with Snapcraft 6 and Launchpad. Resolves CRAFT-1489.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#326 sources: allow plus symbol in git url scheme (#321) craft-parts merged Merged support for “+” in Git URL schemes, enabling git+ssh:// sources. The change landed in commit c993a1f9 and is documented in the 1.19.1 changelog.
94%
#325 Release 1.17.1 craft-parts merged Merged release 1.17.1 in commit 60ea8a5b, adding support for '+' in Git URL schemes, including git+ssh, via #321.
79%
#408 sources: add 'git+ssh:' for 'git' source-type craft-parts merged Merged PR #408 (commit e442172e), adding git+ssh:// recognition for git sources so Launchpad clone URLs work without source-type; released in 1.19.1.
72%