← Back to issue list

sources: add 'git+ssh:' for 'git' source-type

View original Github issue

Metadata

Project
craft-parts
Number
#408
Type
pull request
State
merged
Author
AristoChen
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #408 (commit e442172e), adding git+ssh:// recognition for git sources so Launchpad clone URLs work without source-type; released in 1.19.1.

Resolution: closed resolved

Reason: PR #408 was merged as commit e442172e and added the missing git+ssh scheme mapping. The 1.19.1 changelog confirms that git+ssh was allowed in git source types.

Evaluated by: mr-cal-bot

No scores available.

Issue body

By default, the launchpad instruction for clone will contain `git+ssh` When cloning launchpad repo without defining source-type, I will get `Failed to pull source: unable to determine source type of git+ssh://git.launchpad.net/<TEAM>/<PROJECT>+git/<REPO>` - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #408 (commit e442172e), adding git+ssh:// recognition for git sources so Launchpad clone URLs work without source-type; released in 1.19.1.
stealth/space-bunny-alpha — closed resolved Merged PR #408 in commit e442172e, adding git+ssh: support to the git source type so Launchpad clone URLs work without an explicit source-type.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#408 (commits 67d03ad7 and e442172e), adding git+ssh support for git sources and a regression test.
stealth/space-bunny-alpha — closed resolved Merged PR #408 via commit e442172e, adding git+ssh: support to the git source type and regression coverage for Launchpad repository cloning.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#408 (commits 67d03ad7, e442172e), adding git+ssh support for git sources and a regression test.
qwen/qwen3.6-35b-a3b — — Merged. Added git+ssh: support to the git source-type, resolving cloning failures for Launchpad repositories. Approved by a reviewer, passed CI, and includes a new test case.
qwen3.6-35b-a3b-mtp-q6 — — Added git+ssh: support to the git source-type, resolving Launchpad cloning failures. The change was merged after the contributor added a requested test case.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#61 Added 'git@' to the automatic identification of the source snapcraft merged Merged PR #61 via f4bd14e35 added git@ recognition, allowing SSH Git repository URLs to be automatically identified as Git sources.
74%
#321 sources: allow plus symbol in git url scheme craft-parts merged Merged #321 in commit c993a1f9, allowing '+' in Git URL schemes so git+ssh:// source URLs are accepted; shipped in 1.19.1.
72%
#1599125 Allow Launchpad Git URLs snapcraft (launchpad) closed Launchpad Git URLs were addressed through explicit source-type: git support rather than special-casing URL schemes (commit cbd2c6b88).
72%
#326 sources: allow plus symbol in git url scheme (#321) craft-parts merged Merged support for “+” in Git URL schemes, enabling git+ssh:// sources. The change landed in commit c993a1f9 and is documented in the 1.19.1 changelog.
72%