← Back to issue list

sources: allow plus symbol in git url scheme (#321)

View original Github issue

Metadata

Project
craft-parts
Number
#326
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged support for “+” in Git URL schemes, enabling git+ssh:// sources. The change landed in commit c993a1f9 and is documented in the 1.19.1 changelog.

Resolution: closed resolved

Reason: Git URL protocol validation was broadened to accept “+”, with git+ssh:// coverage added. The change merged via PR #321 in commit c993a1f9.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add the plus symbol to valid git protocol scheme to allow entries using `git+ssh://`. This is allowed in Snapcraft 6 and displayed in Launchpad for git repos. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged support for “+” in Git URL schemes, enabling git+ssh:// sources. The change landed in commit c993a1f9 and is documented in the 1.19.1 changelog.
stealth/space-bunny-alpha — closed resolved Merged as canonical/craft-parts#326 (commit c993a1f9), allowing + in Git URL schemes so git+ssh:// sources validate.
qwen/qwen3.6-35b-a3b — — Merged to allow the plus symbol in git URL schemes, enabling git+ssh:// entries. Approved by one reviewer, passed CI checks, and updated two files with four additions and three deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged PR #321 to allow the plus symbol in git URL schemes, enabling git+ssh:// entries. This change aligns with Snapcraft 6 and Launchpad git repository support.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#321 (confidence 99%)

    Directly linked implementation that added support for “+” in Git URL schemes.

Related issues

Issue Project State Summary Similarity
#321 sources: allow plus symbol in git url scheme craft-parts merged Merged #321 in commit c993a1f9, allowing '+' in Git URL schemes so git+ssh:// source URLs are accepted; shipped in 1.19.1.
94%
#325 Release 1.17.1 craft-parts merged Merged release 1.17.1 in commit 60ea8a5b, adding support for '+' in Git URL schemes, including git+ssh, via #321.
75%
#408 sources: add 'git+ssh:' for 'git' source-type craft-parts merged Merged PR #408 (commit e442172e), adding git+ssh:// recognition for git sources so Launchpad clone URLs work without source-type; released in 1.19.1.
72%