linters: fix new ruff issues
Metadata
Current evaluation
Merged in canonical/craft-parts#349 at commit eabd0bca, allowing temporary-directory paths in tests and marking SHA-1 use as non-security for newer Ruff releases.
Resolution: closed resolved
Reason: PR #349 was approved and merged as commit eabd0bca, resolving the new Ruff findings with targeted lint configuration and annotations.
Evaluated by: mr-cal-bot
No scores available.
Issue body
ruff is a newish tool and it's getting a lot of new releases; we don't currently pin it and the latest versions need two fixes: be more permissive with temporary dirs in tests, and mark that hashlib.sha1() is not being used for security.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-parts#349 at commit eabd0bca, allowing temporary-directory paths in tests and marking SHA-1 use as non-security for newer Ruff releases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #349 (commit eabd0bca), fixing new Ruff warnings by allowing temporary-directory paths in tests and marking hashlib.sha1() as non-security use. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. Adjusted ruff configuration to permit temporary directories in tests and marked hashlib.sha1() as non-security usage, resolving new linter warnings. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for two new ruff linter issues. The update permits temporary directories in tests and explicitly marks hashlib.sha1() usage as non-security related. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #33 lint: fix lint issues with newer ruff | craft-archives | merged | PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641. | |
| #4012 linters: migrate to ruff | snapcraft | merged | Merged PR #4012 (commit a6e7d5f9d, CRAFT-1505): replaced the flake8/isort/black lint setup with Ruff, config ported from craft-parts#337, plus a legacy-specific ruff.toml; dependency updates from #4011 were included. | |
| #1662 style(lint): auto-fix with ruff | craft-parts | merged | Merged Ruff auto-fixes across six files after maintainer review; canonical/craft-parts#1662 landed as commit 2be2b462 (+80/-58). | |
| #580 style(ruff): fix linting issues from ruff update | craft-application | merged | Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers. | |
| #901 style: fix ruff 0.13 linting issues | craft-application | merged | Merged in canonical/craft-application#901 via commit 0a659742, fixing Ruff 0.13 linting with a one-line change; review was approved and all CI checks passed. | |
| #1465 style: fix linting issues for newer ruff | craft-parts | merged | Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed. | |
| #68 lint: update ruff and fix linting | craft-archives | merged | Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67. | |
| #803 style: fix linting issues with ruff 0.12 | craft-application | merged | Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804. | |
| #173 style: fix lint for ruff 0.12 | craft-archives | merged | Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed. | |
| #55 lint: stricter ruff rules | starbase | merged | Merged PR canonical/starbase#55 as b5cda0d, tightening Ruff lint rules in one file (+23/-9) after maintainer approval. |