← Back to issue list

linters: fix new ruff issues

View original Github issue

Metadata

Project
craft-parts
Number
#349
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. Adjusted ruff configuration to permit temporary directories in tests and marked hashlib.sha1() as non-security usage, resolving new linter warnings.

Suggested action:

No scores available.

Issue body

ruff is a newish tool and it's getting a lot of new releases; we don't currently pin it and the latest versions need two fixes: be more permissive with temporary dirs in tests, and mark that hashlib.sha1() is not being used for security. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI. Adjusted ruff configuration to permit temporary directories in tests and marked hashlib.sha1() as non-security usage, resolving new linter warnings.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for two new ruff linter issues. The update permits temporary directories in tests and explicitly marks hashlib.sha1() usage as non-security related.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
81%
#4012 linters: migrate to ruff snapcraft merged Migrated linters to Ruff with a legacy-specific ruff.toml. Approved by two reviewers, passed CI with 100% diff coverage, and merged into main with 167 additions and 35 deletions across 20 files.
80%
#68 lint: update ruff and fix linting craft-archives merged Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change.
79%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged after two approvals and passing all CI checks. Resolves linting compatibility issues with newer ruff versions, updating five files.
78%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
78%
#1323 style: fix new ruff warnings rockcraft merged Merged after approval by two reviewers. Resolves new ruff linting warnings by manually adjusting code across three files. CI checks passed prior to integration.
78%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
78%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change.
77%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
76%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
76%