← Back to issue list

fix(deb): normalize chisel slices

View original Github issue

Metadata

Project
craft-parts
Number
#592
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged. Normalizes chisel slices during deb unpacking to fix absolute symlinks and prevent external path references. Resolves #578. Approved by two reviewers and passed CI.

Suggested action:

No scores available.

Issue body

(this is the same code as before, but now cherry-picked off of `hotfix/1.26.1`) When stage debs are unpacked, we "normalize" the contents to do things like fix absolute symlinks (as absolute links would point outside the lifecycle environment). Do the same for cut chisel slices too. Fixes #578 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Normalizes chisel slices during deb unpacking to fix absolute symlinks and prevent external path references. Resolves #578. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to normalize chisel slices during deb unpacking, resolving absolute symlink issues outside the lifecycle environment. The change was cherry-picked from hotfix/1.26.1 and closes issue #578.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#590 fix(deb): normalize chisel slices craft-parts closed Merged fix normalizing chisel slices during deb unpacking to correct absolute symlinks, resolving issue #578. Approved by two reviewers with passing CI checks.
98%
#279 spec: add "stage-slices" for chisel slices craft-parts merged Merged the addition of a stage-slices specification to handle chisel slice naming conventions, which require underscores unlike standard .deb packages. Approved by one reviewer, modified two files, and resolved CRAFT-1329.
73%
#1715 refactor: put chisel call in its own module craft-parts merged Merged refactoring that extracts the chisel call into a dedicated module, decoupling slice cutting from path normalization to support upcoming build-slices changes. Approved by two reviewers.
72%
#611 Release 1.26.1 craft-parts merged Merged release 1.26.1 following approval from two reviewers and successful CI checks. The update resolves chisel slice normalization issues and addresses Sphinx warnings across five files.
72%
#281 unpack chisel slices craft-parts merged Merged implementation to unpack chisel slices via PullState routing from pull to build step. Updated CI Go version, added integration tests, and verified locally. Approved by two reviewers, +365/-66 lines across 8 files.
71%
#4568 chore(deps): bump version of Chisel (#4522) snapcraft merged Merged dependency update bumping Chisel version. Approved by two reviewers, passed CI, and cherry-picked onto the feature/components branch. Single-file change with minimal modifications.
71%
#578 Run `normalize()` when cutting chisel slices craft-parts closed Closed without implementation or linked pull request. The request to invoke normalize() during chisel slice cutting to fix absolute symlink paths was abandoned.
70%