fix(deb): normalize chisel slices
Metadata
Current evaluation
Merged PR #592 as commit 26d4f9ed, normalizing unpacked Chisel slices to rewrite absolute symlinks and prevent them escaping the lifecycle environment; fixes #578.
Resolution: closed resolved
Reason: PR #592 was merged as commit 26d4f9ed. Its slice-unpacking path now calls normalize() after chisel.cut_slices(), implementing the fix linked to issue #578.
Evaluated by: mr-cal-bot
No scores available.
Issue body
(this is the same code as before, but now cherry-picked off of `hotfix/1.26.1`)
When stage debs are unpacked, we "normalize" the contents to do things like fix absolute symlinks (as absolute links would point outside the lifecycle environment). Do the same for cut chisel slices too.
Fixes #578
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #592 as commit 26d4f9ed, normalizing unpacked Chisel slices to rewrite absolute symlinks and prevent them escaping the lifecycle environment; fixes #578. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #592 (commit 26d4f9ed), normalizing chisel slices during deb unpacking to fix absolute symlinks and close #578. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Normalizes chisel slices during deb unpacking to fix absolute symlinks and prevent external path references. Resolves #578. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to normalize chisel slices during deb unpacking, resolving absolute symlink issues outside the lifecycle environment. The change was cherry-picked from hotfix/1.26.1 and closes issue #578. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#578
(confidence 100%)
PR #592 explicitly states that it fixes issue #578.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #590 fix(deb): normalize chisel slices | craft-parts | closed | Chisel-slice normalization was superseded by #592 and merged as commit 26d4f9ed, fixing absolute symlinks in DEB slices and resolving #578. | |
| #578 Run `normalize()` when cutting chisel slices | craft-parts | closed | Fixed by merged PR #592 (commit 26d4f9ed), which normalizes unpacked Chisel slices and rewrites absolute symlinks. | |
| #1715 refactor: put chisel call in its own module | craft-parts | merged | Merged PR #1715 in commit 0d154d79, extracting Chisel slice-cutting logic into its own module to separate cutting from Repository path normalization before build-slices support. | |
| #281 unpack chisel slices | craft-parts | merged | Merged PR #281 as commit 17c119ea, adding Chisel slice unpacking by passing slices from pull to build via PullState, with CI integration coverage. | |
| #1119 chore: rebuild to bump chisel | rockcraft | merged | Merged #1119 via commit 9f52bf52, bumping Chisel to v1.4.0+ for 26.04 v3 repositories and adding slice coverage and a changelog entry. |