refactor: put chisel call in its own module
Metadata
Current evaluation
Merged refactoring that extracts the chisel call into a dedicated module, decoupling slice cutting from path normalization to support upcoming build-slices changes. Approved by two reviewers.
Suggested action: —
No scores available.
Issue body
This is to facilitate upcoming changes (build-slices). The existing codepath to handle slices in the Repository is kept because that step needs path normalization (fixing symlinks, etc), which needs the Repository itself. So it makes sense to decouple the cutting from the normalizing.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that extracts the chisel call into a dedicated module, decoupling slice cutting from path normalization to support upcoming build-slices changes. Approved by two reviewers. | |
| qwen/qwen3.6-35b-a3b |
Impact:
40
Quick Win:
28.0
Staleness:
5
Complexity:
30
Confidence:
70
|
needs review | Refactors chisel call into its own module to facilitate build-slices changes. Approved by 2 reviewers with most CI checks passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
40
Quick Win:
26.0
Staleness:
5
Complexity:
35
Confidence:
80
|
needs review | Refactors chisel call into its own module to decouple cutting from path normalization, facilitating upcoming build-slices changes. Has 1 approval, 2 unresolved review comments, CI passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
40
Quick Win:
28.0
Staleness:
5
Complexity:
30
Confidence:
70
|
needs review | Refactors chisel call into its own module to decouple cutting from path normalization, facilitating upcoming build-slices changes. Fresh PR with passing CI, awaiting review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
22.5
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Refactors chisel call into its own module to decouple cutting from normalizing, preparing for build-slices changes. Fresh PR with 3 unresolved review comments and one failing lint check. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #281 unpack chisel slices | craft-parts | merged | Merged implementation to unpack chisel slices via PullState routing from pull to build step. Updated CI Go version, added integration tests, and verified locally. Approved by two reviewers, +365/-66 lines across 8 files. | |
| #279 spec: add "stage-slices" for chisel slices | craft-parts | merged | Merged the addition of a stage-slices specification to handle chisel slice naming conventions, which require underscores unlike standard .deb packages. Approved by one reviewer, modified two files, and resolved CRAFT-1329. | |
| #592 fix(deb): normalize chisel slices | craft-parts | merged | Merged. Normalizes chisel slices during deb unpacking to fix absolute symlinks and prevent external path references. Resolves #578. Approved by two reviewers and passed CI. | |
| #590 fix(deb): normalize chisel slices | craft-parts | closed | Merged fix normalizing chisel slices during deb unpacking to correct absolute symlinks, resolving issue #578. Approved by two reviewers with passing CI checks. |