refactor: put chisel call in its own module
Metadata
Current evaluation
Merged PR #1715 in commit 0d154d79, extracting Chisel slice-cutting logic into its own module to separate cutting from Repository path normalization before build-slices support.
Resolution: closed resolved
Reason: PR #1715 was approved and merged as commit 0d154d79. Its new chisel module was subsequently used by merged PR #1718 (2adcb0c1) to cut build-slices.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is to facilitate upcoming changes (build-slices). The existing codepath to handle slices in the Repository is kept because that step needs path normalization (fixing symlinks, etc), which needs the Repository itself. So it makes sense to decouple the cutting from the normalizing.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1715 in commit 0d154d79, extracting Chisel slice-cutting logic into its own module to separate cutting from Repository path normalization before build-slices support. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1715 as commit 0d154d79, moving the Chisel invocation into a dedicated module to separate slice cutting from Repository path normalization ahead of build-slices. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1715 (commit 0d154d79), extracting the Chisel call into its own module to decouple slice cutting from Repository path normalization ahead of build-slices work. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that extracts the chisel call into a dedicated module, decoupling slice cutting from path normalization to support upcoming build-slices changes. Approved by two reviewers. | |
| qwen/qwen3.6-35b-a3b |
Impact:
40
Quick Win:
28
Staleness:
5
Complexity:
30
Confidence:
70
|
needs review | Refactors chisel call into its own module to facilitate build-slices changes. Approved by 2 reviewers with most CI checks passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
40
Quick Win:
26
Staleness:
5
Complexity:
35
Confidence:
80
|
needs review | Refactors chisel call into its own module to decouple cutting from path normalization, facilitating upcoming build-slices changes. Has 1 approval, 2 unresolved review comments, CI passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
40
Quick Win:
28
Staleness:
5
Complexity:
30
Confidence:
70
|
needs review | Refactors chisel call into its own module to decouple cutting from path normalization, facilitating upcoming build-slices changes. Fresh PR with passing CI, awaiting review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
22
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Refactors chisel call into its own module to decouple cutting from normalizing, preparing for build-slices changes. Fresh PR with 3 unresolved review comments and one failing lint check. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/craft-parts#1718
(confidence 98%)
Implemented the planned build-slices feature using the Chisel-cutting module introduced by #1715.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #281 unpack chisel slices | craft-parts | merged | Merged PR #281 as commit 17c119ea, adding Chisel slice unpacking by passing slices from pull to build via PullState, with CI integration coverage. | |
| #592 fix(deb): normalize chisel slices | craft-parts | merged | Merged PR #592 as commit 26d4f9ed, normalizing unpacked Chisel slices to rewrite absolute symlinks and prevent them escaping the lifecycle environment; fixes #578. | |
| #578 Run `normalize()` when cutting chisel slices | craft-parts | closed | Fixed by merged PR #592 (commit 26d4f9ed), which normalizes unpacked Chisel slices and rewrites absolute symlinks. | |
| #1119 chore: rebuild to bump chisel | rockcraft | merged | Merged #1119 via commit 9f52bf52, bumping Chisel to v1.4.0+ for 26.04 v3 repositories and adding slice coverage and a changelog entry. | |
| #279 spec: add "stage-slices" for chisel slices | craft-parts | merged | Merged PR #279, adding stage-slices so Chisel slices are declared separately from stage-packages; support is documented in Craft Parts 2.36.0. | |
| #271 Split chisel explanation | rockcraft | merged | Merged in PR #271 as commit 073078a0, splitting the Chisel explanation and clarifying its overview and diagram. | |
| #1737 fix: install chisel for build-slices | craft-parts | closed | Merged #1737 as commit 46fb937b: Chisel is now installed automatically when any part declares build-slices. The fix is recorded in craft-parts 2.37.1. |